From: "Michael Frank" <mhf@linuxmail.org>
To: "Roland Dreier" <roland@topspin.com>,
"Horst von Brand" <vonbrand@inf.utfsm.cl>
Cc: "Eyal Lebedinsky" <eyal@eyal.emu.id.au>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.26-pre2
Date: Mon, 08 Mar 2004 03:42:59 +0800 [thread overview]
Message-ID: <opr4ibpxlt4evsfm@smtp.pacific.net.th> (raw)
In-Reply-To: <52y8qcv6fy.fsf@topspin.com>
On 07 Mar 2004 10:49:05 -0800, Roland Dreier <roland@topspin.com> wrote:
> Eyal> In standard C we declare all variables at the top of a
> Eyal> function. While some compilers allow extension, it is not a
> Eyal> good idea to get used to them if we want portable code.
>
> Horst> Oh, come on. This is _kernel_ code, it won't ever be
> Horst> compiled with anything not GCC-compatible.
>
> gcc 2.95 rejects declarations after code. The kernel, especially
> kernel 2.4, shouldn't use this particular extension, even if gcc 3
> accepts it.
>
I also use gcc 2.95 and have no intention to change compilers
for 2.4 at all as this compiler is most dependable and never
screwed up unlike 3.1.x and 3.2.2.
Documentation/Codingstyle also refers to K&R who historically
declare variables at the top of a function.
Excerpt:
"all right-thinking people know that
(a) K&R are _right_ and (b) K&R are right"
Regards
Michael
next prev parent reply other threads:[~2004-03-07 19:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-06 19:20 Marcelo Tosatti
2004-03-07 5:44 ` Eyal Lebedinsky
2004-03-07 16:19 ` Horst von Brand
2004-03-07 18:49 ` Roland Dreier
2004-03-07 19:42 ` Michael Frank [this message]
2004-03-07 19:25 ` David Weinehall
2004-03-07 19:52 ` Rene Herman
2004-03-07 19:58 ` Jeff Garzik
2004-03-07 20:05 ` David Weinehall
2004-03-07 20:58 ` Michael Frank
2004-03-07 20:08 ` Michal Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=opr4ibpxlt4evsfm@smtp.pacific.net.th \
--to=mhf@linuxmail.org \
--cc=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®