From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 24/29] kernel: Update WARN uses
Date: Mon, 6 Dec 2010 14:05:14 -0800 [thread overview]
Message-ID: <405f6d9400e07f78048aa88307c2cfbc5be4849c.1291670105.git.joe@perches.com> (raw)
In-Reply-To: <cover.1291670104.git.joe@perches.com>
Align arguments.
Add missing newlines.
Remove KERN_<level>.
Signed-off-by: Joe Perches <joe@perches.com>
---
kernel/notifier.c | 2 +-
kernel/pm_qos_params.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 2488ba7..ff6a774 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -85,7 +85,7 @@ static int __kprobes notifier_call_chain(struct notifier_block **nl,
#ifdef CONFIG_DEBUG_NOTIFIERS
if (unlikely(!func_ptr_is_kernel_text(nb->notifier_call))) {
- WARN(1, "Invalid notifier called!");
+ WARN(1, "Invalid notifier called!\n");
nb = next_nb;
continue;
}
diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
index aeaa7f8..a7abb8b 100644
--- a/kernel/pm_qos_params.c
+++ b/kernel/pm_qos_params.c
@@ -231,7 +231,7 @@ void pm_qos_add_request(struct pm_qos_request_list *dep,
int new_value;
if (pm_qos_request_active(dep)) {
- WARN(1, KERN_ERR "pm_qos_add_request() called for already added request\n");
+ WARN(1, "%s() called for already added request\n", __func__);
return;
}
if (value == PM_QOS_DEFAULT_VALUE)
@@ -264,7 +264,7 @@ void pm_qos_update_request(struct pm_qos_request_list *pm_qos_req,
return;
if (!pm_qos_request_active(pm_qos_req)) {
- WARN(1, KERN_ERR "pm_qos_update_request() called for unknown object\n");
+ WARN(1, "%s() called for unknown object\n", __func__);
return;
}
@@ -297,7 +297,7 @@ void pm_qos_remove_request(struct pm_qos_request_list *pm_qos_req)
/* silent return to keep pcm code cleaner */
if (!pm_qos_request_active(pm_qos_req)) {
- WARN(1, KERN_ERR "pm_qos_remove_request() called for unknown object\n");
+ WARN(1, "%s() called for unknown object\n", __func__);
return;
}
--
1.7.3.2.245.g03276.dirty
next prev parent reply other threads:[~2010-12-06 22:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:04 [PATCH 00/29] trivial: WARN cleanups Joe Perches
2010-12-06 22:04 ` [PATCH 01/29] include/asm-generic/bug.h: Update WARN macros Joe Perches
2010-12-06 22:04 ` [PATCH 02/29] arch/alpha: Update WARN uses Joe Perches
2010-12-06 22:04 ` [PATCH 03/29] arch/arm: " Joe Perches
2010-12-06 22:04 ` [PATCH 04/29] arch/powerpc: " Joe Perches
2010-12-06 22:04 ` [PATCH 05/29] arch/x86: " Joe Perches
2010-12-06 22:04 ` [PATCH 06/29] drivers/acpi: " Joe Perches
2010-12-06 22:04 ` [PATCH 07/29] drivers/base: " Joe Perches
2010-12-06 22:04 ` [PATCH 08/29] drivers/block: " Joe Perches
2010-12-06 22:04 ` [PATCH 09/29] drivers/cpuidle: " Joe Perches
2010-12-06 22:05 ` [PATCH 10/29] drivers/firmware: " Joe Perches
2010-12-06 22:05 ` [PATCH 11/29] drivers/gpio: " Joe Perches
2010-12-06 22:05 ` [PATCH 12/29] drivers/net/wireless/iwlwifi: " Joe Perches
2010-12-06 22:05 ` [PATCH 13/29] drivers/scsi/fcoe: " Joe Perches
2010-12-06 22:05 ` [PATCH 14/29] drivers/usb/musb: " Joe Perches
2010-12-06 22:05 ` [PATCH 15/29] drivers/video/omap2/dss: " Joe Perches
2010-12-06 22:05 ` [PATCH 16/29] fs/nfsd: " Joe Perches
2010-12-06 22:05 ` [PATCH 17/29] fs/notify/inotify: " Joe Perches
2010-12-06 22:05 ` [PATCH 18/29] fs/sysfs: " Joe Perches
2010-12-06 22:05 ` [PATCH 19/29] fs/proc: " Joe Perches
2010-12-06 22:05 ` [PATCH 20/29] fs: " Joe Perches
2010-12-06 22:05 ` [PATCH 21/29] include/linux/device.h: " Joe Perches
2010-12-06 22:05 ` [PATCH 22/29] kernel/irq: " Joe Perches
2010-12-06 22:05 ` [PATCH 23/29] kernel/panic.c: Update warn_slowpath to use %pV Joe Perches
2010-12-06 22:05 ` Joe Perches [this message]
2010-12-06 22:05 ` [PATCH 25/29] lib: Update WARN uses Joe Perches
2010-12-06 22:05 ` [PATCH 26/29] mm: " Joe Perches
2010-12-06 22:05 ` [PATCH 27/29] net/mac80211: " Joe Perches
2010-12-06 22:05 ` [PATCH 28/29] net/rfkill/input.c: " Joe Perches
2010-12-06 22:05 ` [PATCH 29/29] drivers/regulator: " Joe Perches
2010-12-07 11:43 ` Mark Brown
2010-12-07 14:50 ` Jiri Kosina
2010-12-07 15:16 ` Mark Brown
2010-12-07 15:31 ` Jiri Kosina
2010-12-07 15:44 ` Liam Girdwood
2010-12-09 9:10 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405f6d9400e07f78048aa88307c2cfbc5be4849c.1291670105.git.joe@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®