From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 20/29] fs: Update WARN uses
Date: Mon, 6 Dec 2010 14:05:10 -0800 [thread overview]
Message-ID: <e8dd1ca94f24f2b1df3556040a542c701fa13ca4.1291670105.git.joe@perches.com> (raw)
In-Reply-To: <cover.1291670104.git.joe@perches.com>
Coalesce long formats.
Align arguments.
Remove KERN_<level>.
Signed-off-by: Joe Perches <joe@perches.com>
---
fs/bio.c | 2 +-
fs/buffer.c | 2 +-
fs/super.c | 5 +++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/bio.c b/fs/bio.c
index 4bd454f..d366f05 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -134,7 +134,7 @@ static void bio_put_slab(struct bio_set *bs)
}
}
- if (WARN(!bslab, KERN_ERR "bio: unable to find slab!\n"))
+ if (WARN(!bslab, "bio: unable to find slab!\n"))
goto out;
WARN_ON(!bslab->slab_ref);
diff --git a/fs/buffer.c b/fs/buffer.c
index 3a70821..7e060fd 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1191,7 +1191,7 @@ void __brelse(struct buffer_head * buf)
put_bh(buf);
return;
}
- WARN(1, KERN_ERR "VFS: brelse: Trying to free free buffer\n");
+ WARN(1, "VFS: brelse: Trying to free free buffer\n");
}
EXPORT_SYMBOL(__brelse);
diff --git a/fs/super.c b/fs/super.c
index ca51b70..7920ab9 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1012,8 +1012,9 @@ vfs_kern_mount(struct file_system_type *type, int flags, const char *name, void
* violate this rule. This warning should be either removed or
* converted to a BUG() in 2.6.34.
*/
- WARN((mnt->mnt_sb->s_maxbytes < 0), "%s set sb->s_maxbytes to "
- "negative value (%lld)\n", type->name, mnt->mnt_sb->s_maxbytes);
+ WARN((mnt->mnt_sb->s_maxbytes < 0),
+ "%s set sb->s_maxbytes to negative value (%lld)\n",
+ type->name, mnt->mnt_sb->s_maxbytes);
mnt->mnt_mountpoint = mnt->mnt_root;
mnt->mnt_parent = mnt;
--
1.7.3.2.245.g03276.dirty
next prev parent reply other threads:[~2010-12-06 22:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 22:04 [PATCH 00/29] trivial: WARN cleanups Joe Perches
2010-12-06 22:04 ` [PATCH 01/29] include/asm-generic/bug.h: Update WARN macros Joe Perches
2010-12-06 22:04 ` [PATCH 02/29] arch/alpha: Update WARN uses Joe Perches
2010-12-06 22:04 ` [PATCH 03/29] arch/arm: " Joe Perches
2010-12-06 22:04 ` [PATCH 04/29] arch/powerpc: " Joe Perches
2010-12-06 22:04 ` [PATCH 05/29] arch/x86: " Joe Perches
2010-12-06 22:04 ` [PATCH 06/29] drivers/acpi: " Joe Perches
2010-12-06 22:04 ` [PATCH 07/29] drivers/base: " Joe Perches
2010-12-06 22:04 ` [PATCH 08/29] drivers/block: " Joe Perches
2010-12-06 22:04 ` [PATCH 09/29] drivers/cpuidle: " Joe Perches
2010-12-06 22:05 ` [PATCH 10/29] drivers/firmware: " Joe Perches
2010-12-06 22:05 ` [PATCH 11/29] drivers/gpio: " Joe Perches
2010-12-06 22:05 ` [PATCH 12/29] drivers/net/wireless/iwlwifi: " Joe Perches
2010-12-06 22:05 ` [PATCH 13/29] drivers/scsi/fcoe: " Joe Perches
2010-12-06 22:05 ` [PATCH 14/29] drivers/usb/musb: " Joe Perches
2010-12-06 22:05 ` [PATCH 15/29] drivers/video/omap2/dss: " Joe Perches
2010-12-06 22:05 ` [PATCH 16/29] fs/nfsd: " Joe Perches
2010-12-06 22:05 ` [PATCH 17/29] fs/notify/inotify: " Joe Perches
2010-12-06 22:05 ` [PATCH 18/29] fs/sysfs: " Joe Perches
2010-12-06 22:05 ` [PATCH 19/29] fs/proc: " Joe Perches
2010-12-06 22:05 ` Joe Perches [this message]
2010-12-06 22:05 ` [PATCH 21/29] include/linux/device.h: " Joe Perches
2010-12-06 22:05 ` [PATCH 22/29] kernel/irq: " Joe Perches
2010-12-06 22:05 ` [PATCH 23/29] kernel/panic.c: Update warn_slowpath to use %pV Joe Perches
2010-12-06 22:05 ` [PATCH 24/29] kernel: Update WARN uses Joe Perches
2010-12-06 22:05 ` [PATCH 25/29] lib: " Joe Perches
2010-12-06 22:05 ` [PATCH 26/29] mm: " Joe Perches
2010-12-06 22:05 ` [PATCH 27/29] net/mac80211: " Joe Perches
2010-12-06 22:05 ` [PATCH 28/29] net/rfkill/input.c: " Joe Perches
2010-12-06 22:05 ` [PATCH 29/29] drivers/regulator: " Joe Perches
2010-12-07 11:43 ` Mark Brown
2010-12-07 14:50 ` Jiri Kosina
2010-12-07 15:16 ` Mark Brown
2010-12-07 15:31 ` Jiri Kosina
2010-12-07 15:44 ` Liam Girdwood
2010-12-09 9:10 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8dd1ca94f24f2b1df3556040a542c701fa13ca4.1291670105.git.joe@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®