mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [v2 PATCH 2/3] EDAC: Add edac_device_alloc_index()
@ 2009-04-17 21:42 Doug Thompson
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Thompson @ 2009-04-17 21:42 UTC (permalink / raw)
  To: Harry Ciao, Andrew Morton
  Cc: michael, bluesmoke-devel, linuxppc-dev, linux-kernel


--- On Wed, 4/15/09, Andrew Morton <akpm@linux-foundation.org> wrote:

> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: Re: [v2 PATCH 2/3] EDAC: Add edac_device_alloc_index()
> To: "Harry Ciao" <qingtao.cao@windriver.com>
> Cc: norsk5@yahoo.com, michael@ellerman.id.au, bluesmoke-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
> Date: Wednesday, April 15, 2009, 4:27 PM
> On Mon, 13 Apr 2009 14:05:15 +0800
> Harry Ciao <qingtao.cao@windriver.com>
> wrote:
> 
> > Add edac_device_alloc_index(), because for MAPLE
> platform there may
> > exist several EDAC driver modules that could make use
> of
> > edac_device_ctl_info structure at the same time. The
> index allocation
> > for these structures should be taken care of by EDAC
> core.
> > 
> 
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> keep things neat.  Also avoids having global
> identifier device_index
> shadowed by local identifier device_index.
> 
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Acked-by: Doug Thompson <dougthompson@xmission.com>

> Cc: Harry Ciao <qingtao.cao@windriver.com>
> Cc: Kumar Gala <galak@gate.crashing.org>
> Cc: Michael Ellerman <michael@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/edac/edac_device.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -puN
> drivers/edac/amd8111_edac.c~edac-add-edac_device_alloc_index-cleanup
> drivers/edac/amd8111_edac.c
> diff -puN
> drivers/edac/edac_core.h~edac-add-edac_device_alloc_index-cleanup
> drivers/edac/edac_core.h
> diff -puN
> drivers/edac/edac_device.c~edac-add-edac_device_alloc_index-cleanup
> drivers/edac/edac_device.c
> ---
> a/drivers/edac/edac_device.c~edac-add-edac_device_alloc_index-cleanup
> +++ a/drivers/edac/edac_device.c
> @@ -37,7 +37,6 @@
>   */
>  static DEFINE_MUTEX(device_ctls_mutex);
>  static LIST_HEAD(edac_device_list);
> -static atomic_t device_indexes = ATOMIC_INIT(0);
>  
>  #ifdef CONFIG_EDAC_DEBUG
>  static void edac_device_dump_device(struct
> edac_device_ctl_info *edac_dev)
> @@ -499,6 +498,8 @@ void
> edac_device_reset_delay_period(stru
>   */
>  int edac_device_alloc_index(void)
>  {
> +    static atomic_t device_indexes =
> ATOMIC_INIT(0);
> +
>      return
> atomic_inc_return(&device_indexes) - 1;
>  }
>  EXPORT_SYMBOL_GPL(edac_device_alloc_index);
> _
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [v2 PATCH 0/3] Add CPC925 Memory Controller EDAC drivers
@ 2009-04-13  6:05 Harry Ciao
  2009-04-13  6:05 ` [v2 PATCH 1/3] EDAC: Add CPC925 Memory Controller driver Harry Ciao
  0 siblings, 1 reply; 3+ messages in thread
From: Harry Ciao @ 2009-04-13  6:05 UTC (permalink / raw)
  To: norsk5, michael, bluesmoke-devel, linuxppc-dev; +Cc: linux-kernel


Hi Doug and Michael,

This is the latest v2 patches, the 1/3 of CPC925 MC EDAC driver remains
the same as before, the 2/3 has been pushed to Andrew already, and the 
3/3 has integrated Michael's suggestions to add a fixup routine for the 
memory controller on Maple that has incorrect number of cells, and create
related platform_device for CPC925 on Motorola ATCA-6101 target by far.

All patches have been tested, please give me your further concerns or 
suggestions, thanks!

Best regards,

Harry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-04-17 21:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-17 21:42 [v2 PATCH 2/3] EDAC: Add edac_device_alloc_index() Doug Thompson
  -- strict thread matches above, loose matches on Subject: below --
2009-04-13  6:05 [v2 PATCH 0/3] Add CPC925 Memory Controller EDAC drivers Harry Ciao
2009-04-13  6:05 ` [v2 PATCH 1/3] EDAC: Add CPC925 Memory Controller driver Harry Ciao
2009-04-13  6:05   ` [v2 PATCH 2/3] EDAC: Add edac_device_alloc_index() Harry Ciao
2009-04-15 22:27     ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome