From: "" <jszhang3@mail.ustc.edu.cn>
To: krh@redhat.com
Cc: stefanr@s5r6.in-berlin.de, linux-kernel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net
Subject: [PATCH] firewire: fix sourceID read from wrong quadlet
Date: Wed, 16 Apr 2008 20:43:22 +0800 [thread overview]
Message-ID: <408349802.26451@ustc.edu.cn> (raw)
>From JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
In Asynchronous Receive Requests, the sourceID is in the second quadlet(OHCI
specification, section 8.7.1).
--- linux-2.6.24.4/drivers/firewire/fw-transaction.c.orig 2008-04-14
20:57:48.294718721 +0800
+++ linux-2.6.24.4/drivers/firewire/fw-transaction.c 2008-04-14
20:58:07.083525930 +0800
@@ -650,7 +650,7 @@ fw_core_handle_request(struct fw_card *c
HEADER_GET_OFFSET_HIGH(p->header[1]) << 32) | p->header[2];
tcode = HEADER_GET_TCODE(p->header[0]);
destination = HEADER_GET_DESTINATION(p->header[0]);
- source = HEADER_GET_SOURCE(p->header[0]);
+ source = HEADER_GET_SOURCE(p->header[1]);
spin_lock_irqsave(&address_handler_lock, flags);
handler = lookup_enclosing_address_handler(&address_handler_list,
next reply other threads:[~2008-04-16 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 12:43 jszhang3 [this message]
2008-04-16 13:06 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408349802.26451@ustc.edu.cn \
--to=jszhang3@mail.ustc.edu.cn \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®