* [PATCH] firewire: fix sourceID read from wrong quadlet
@ 2008-04-16 12:43 jszhang3
2008-04-16 13:06 ` Stefan Richter
0 siblings, 1 reply; 2+ messages in thread
From: jszhang3 @ 2008-04-16 12:43 UTC (permalink / raw)
To: krh; +Cc: stefanr, linux-kernel, linux1394-devel
>From JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
In Asynchronous Receive Requests, the sourceID is in the second quadlet(OHCI
specification, section 8.7.1).
--- linux-2.6.24.4/drivers/firewire/fw-transaction.c.orig 2008-04-14
20:57:48.294718721 +0800
+++ linux-2.6.24.4/drivers/firewire/fw-transaction.c 2008-04-14
20:58:07.083525930 +0800
@@ -650,7 +650,7 @@ fw_core_handle_request(struct fw_card *c
HEADER_GET_OFFSET_HIGH(p->header[1]) << 32) | p->header[2];
tcode = HEADER_GET_TCODE(p->header[0]);
destination = HEADER_GET_DESTINATION(p->header[0]);
- source = HEADER_GET_SOURCE(p->header[0]);
+ source = HEADER_GET_SOURCE(p->header[1]);
spin_lock_irqsave(&address_handler_lock, flags);
handler = lookup_enclosing_address_handler(&address_handler_list,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] firewire: fix sourceID read from wrong quadlet
2008-04-16 12:43 [PATCH] firewire: fix sourceID read from wrong quadlet jszhang3
@ 2008-04-16 13:06 ` Stefan Richter
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Richter @ 2008-04-16 13:06 UTC (permalink / raw)
To: jszhang3; +Cc: krh, linux-kernel, linux1394-devel
jszhang3@mail.ustc.edu.cn wrote:
> From JiSheng Zhang <jszhang3@mail.ustc.edu.cn>
>
> In Asynchronous Receive Requests, the sourceID is in the second quadlet(OHCI
> specification, section 8.7.1).
This has been fixed in Linux 2.6.25-rc1 by commit
478b233eda81bfe41307512b8336fd688c6553e0 . Thank you nevertheless,
--
Stefan Richter
-=====-==--- -=-- =----
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-16 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-16 12:43 [PATCH] firewire: fix sourceID read from wrong quadlet jszhang3
2008-04-16 13:06 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®