mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] crypto: AF_ALG: zeroize key data
@ 2014-12-23  8:34 Stephan Mueller
  2014-12-25 22:46 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Stephan Mueller @ 2014-12-23  8:34 UTC (permalink / raw)
  To: 'Herbert Xu'; +Cc: 'LKML', linux-crypto

alg_setkey should zeroize the sensitive data after use.

Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
 crypto/af_alg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/af_alg.c b/crypto/af_alg.c
index a8ff3c4..76d739d 100644
--- a/crypto/af_alg.c
+++ b/crypto/af_alg.c
@@ -188,7 +188,7 @@ static int alg_setkey(struct sock *sk, char __user *ukey,
 	err = type->setkey(ask->private, key, keylen);
 
 out:
-	sock_kfree_s(sk, key, keylen);
+	sock_kzfree_s(sk, key, keylen);
 
 	return err;
 }
-- 
2.1.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: AF_ALG: zeroize key data
  2014-12-23  8:34 [PATCH] crypto: AF_ALG: zeroize key data Stephan Mueller
@ 2014-12-25 22:46 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2014-12-25 22:46 UTC (permalink / raw)
  To: Stephan Mueller; +Cc: 'LKML', linux-crypto

On Tue, Dec 23, 2014 at 09:34:03AM +0100, Stephan Mueller wrote:
> alg_setkey should zeroize the sensitive data after use.
> 
> Signed-off-by: Stephan Mueller <smueller@chronox.de>

Patch applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-25 22:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-23  8:34 [PATCH] crypto: AF_ALG: zeroize key data Stephan Mueller
2014-12-25 22:46 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®