* [PATCH] nvmet-rdma: WARN_ON when nvmet_rdma_rsp::n_rdma equal zero
@ 2024-11-02 6:39 Honggang LI
2024-11-02 23:50 ` Chaitanya Kulkarni
0 siblings, 1 reply; 2+ messages in thread
From: Honggang LI @ 2024-11-02 6:39 UTC (permalink / raw)
To: hch, sagi, kch; +Cc: linux-nvme, linux-kernel, Honggang LI
nvmet_rdma_rsp::n_rdma is an u8, which can't be negative.
Signed-off-by: Honggang LI <honggangli@163.com>
---
drivers/nvme/target/rdma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 1afd93026f9b..cdeb275a388b 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -750,7 +750,7 @@ static void nvmet_rdma_read_data_done(struct ib_cq *cq, struct ib_wc *wc)
struct nvmet_rdma_queue *queue = wc->qp->qp_context;
u16 status = 0;
- WARN_ON(rsp->n_rdma <= 0);
+ WARN_ON(rsp->n_rdma == 0);
atomic_add(rsp->n_rdma, &queue->sq_wr_avail);
rsp->n_rdma = 0;
@@ -787,7 +787,7 @@ static void nvmet_rdma_write_data_done(struct ib_cq *cq, struct ib_wc *wc)
if (!IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY))
return;
- WARN_ON(rsp->n_rdma <= 0);
+ WARN_ON(rsp->n_rdma == 0);
atomic_add(rsp->n_rdma, &queue->sq_wr_avail);
rsp->n_rdma = 0;
--
2.47.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmet-rdma: WARN_ON when nvmet_rdma_rsp::n_rdma equal zero
2024-11-02 6:39 [PATCH] nvmet-rdma: WARN_ON when nvmet_rdma_rsp::n_rdma equal zero Honggang LI
@ 2024-11-02 23:50 ` Chaitanya Kulkarni
0 siblings, 0 replies; 2+ messages in thread
From: Chaitanya Kulkarni @ 2024-11-02 23:50 UTC (permalink / raw)
To: Honggang LI, hch, sagi, Chaitanya Kulkarni; +Cc: linux-nvme, linux-kernel
On 11/1/24 23:39, Honggang LI wrote:
> nvmet_rdma_rsp::n_rdma is an u8, which can't be negative.
>
> Signed-off-by: Honggang LI<honggangli@163.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-02 23:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-02 6:39 [PATCH] nvmet-rdma: WARN_ON when nvmet_rdma_rsp::n_rdma equal zero Honggang LI
2024-11-02 23:50 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®