mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Allen Martin <AMartin@nvidia.com>,
	linux-kernel@vger.kernel.org,
	Ross Dickson <ross@datscreative.com.au>,
	Len Brown <len.brown@intel.com>
Subject: Re: IO-APIC on nforce2 [PATCH] + [PATCH] for nmi_debug=1 + [PATCH] for idle=C1halt, 2.6.5
Date: Tue, 04 May 2004 17:10:30 -0400	[thread overview]
Message-ID: <409806C6.3060300@pobox.com> (raw)
In-Reply-To: <200405040111.01514.bzolnier@elka.pw.edu.pl>

Bartlomiej Zolnierkiewicz wrote:
> +/*
> + * Fixup for C1 Halt Disconnect problem on nForce2 systems.
> + *
> + * From information provided by "Allen Martin" <AMartin@nvidia.com>:
> + *
> + * A hang is caused when the CPU generates a very fast CONNECT/HALT cycle
> + * sequence.  Workaround is to set the SYSTEM_IDLE_TIMEOUT to 80 ns.
> + * This allows the state-machine and timer to return to a proper state within
> + * 80 ns of the CONNECT and probe appearing together.  Since the CPU will not
> + * issue another HALT within 80 ns of the initial HALT, the failure condition
> + * is avoided.
> + */
> +static void __devinit pci_fixup_nforce2(struct pci_dev *dev)


Minor nit:  is __devinit really needed?

You're changing a northbridge or a southbridge, not a PCI card, I 
presume...?  That would only need to be done once, when the kernel is 
booted, regardless of CONFIG_HOTPLUG AFAICS.

	Jeff




  parent reply	other threads:[~2004-05-04 21:12 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-03 22:09 Allen Martin
2004-05-03 23:11 ` Bartlomiej Zolnierkiewicz
2004-05-04  8:28   ` Prakash K. Cheemplavam
2004-05-04 21:10   ` Jeff Garzik [this message]
2004-05-04 21:29     ` Bartlomiej Zolnierkiewicz
2004-05-05 12:14   ` Ross Dickson
2004-05-05 12:27     ` Ian Kumlien
2004-05-05 13:12       ` Ross Dickson
2004-05-05 13:23         ` Ian Kumlien
2004-05-05 12:58     ` Maciej W. Rozycki
2004-05-05 12:48   ` Patrick Dreker
2004-05-05 13:34     ` Patrick Dreker
2004-05-05 11:24 ` Ross Dickson
2004-05-05 12:18   ` Ian Kumlien
2004-05-05 12:52     ` Ross Dickson
2004-05-05 13:08       ` Ian Kumlien
2004-05-06  1:50         ` Jesse Allen
  -- strict thread matches above, loose matches on Subject: below --
2004-05-04 20:38 Jesse Allen
2004-05-04 21:14 ` Craig Bradney
2004-05-03  8:08 Allen Martin
2004-04-23  1:30 Jesse Allen
2004-05-07  4:47 ` Richard James
2004-05-07  7:13   ` Craig Bradney
2004-05-08  5:33   ` Richard James
     [not found] <1KkKQ-2v9-9@gated-at.bofh.it>
     [not found] ` <1Kqdx-6E1-5@gated-at.bofh.it>
     [not found]   ` <1KH4I-3W9-11@gated-at.bofh.it>
     [not found]     ` <1LgOQ-7px-3@gated-at.bofh.it>
     [not found]       ` <1LlEY-36q-11@gated-at.bofh.it>
2004-04-15 23:07         ` Andi Kleen
2004-04-21 22:00           ` Len Brown
2004-04-13  1:17 IO-APIC on nforce2 Ross Dickson
2004-04-13  7:03 ` Ross Dickson
2004-04-14  1:02   ` IO-APIC on nforce2 [PATCH] Len Brown
2004-04-15 15:10     ` IO-APIC on nforce2 [PATCH] + [PATCH] for nmi_debug=1 + [PATCH] for idle=C1halt, 2.6.5 Ross Dickson
2004-04-15 20:17       ` Len Brown
2004-04-15 21:04         ` Craig Bradney
2004-04-21 20:22           ` Len Brown
2004-04-21 20:33             ` Ian Kumlien
2004-04-21 20:45             ` Craig Bradney
2004-04-21 21:28             ` Prakash K. Cheemplavam
2004-04-21 22:41               ` Len Brown
2004-04-22  7:26                 ` Prakash K. Cheemplavam
2004-04-22 14:58                   ` Len Brown
2004-04-22  8:45                 ` Craig Bradney
2004-04-22 15:03                   ` Len Brown
2004-04-22 20:50                     ` Craig Bradney
2004-04-22  8:50                 ` Arjen Verweij
2004-04-22 16:39                 ` Jesse Allen
2004-04-22 17:21                   ` Len Brown
2004-04-22 21:29                     ` Len Brown
2004-04-23  8:48                       ` Prakash K. Cheemplavam
2004-04-23  9:01                         ` Arjen Verweij
2004-04-23  9:08                           ` Prakash K. Cheemplavam
2004-04-23  9:11                           ` Prakash K. Cheemplavam
2004-04-23 12:18                       ` Maciej W. Rozycki
2004-04-26 11:41                     ` Ross Dickson
2004-04-27 17:02                       ` Arjen Verweij
2004-04-27 17:35                         ` Ian Kumlien
2004-04-27 18:00                         ` Len Brown
2004-04-27 18:24                           ` Arjen Verweij
2004-04-27 18:51                           ` Jussi Laako
2004-04-28 11:33                           ` Ross Dickson
2004-04-28 20:59                             ` Jesse Allen
2004-04-29 11:44                               ` Ross Dickson
2004-04-29 11:54                                 ` Maciej W. Rozycki
2004-04-29 12:00                                   ` Jamie Lokier
2004-04-29 12:26                                     ` Maciej W. Rozycki
2004-04-29 11:57                                 ` Jamie Lokier
2004-04-29 12:16                                 ` Craig Bradney
2004-04-29 20:24                                 ` Jesse Allen
2004-04-29 20:31                                   ` Prakash K. Cheemplavam
2004-05-03 20:45                                     ` Jesse Allen
2004-05-17 15:26                                       ` Prakash K. Cheemplavam
2004-05-17 19:32                                         ` Craig Bradney
2004-05-17 19:37                                           ` Prakash K. Cheemplavam
2004-05-17 19:57                                             ` Craig Bradney
2004-04-27 21:31                       ` Prakash K. Cheemplavam
2004-04-28 11:26                         ` Prakash K. Cheemplavam
2004-05-01  6:51                 ` Prakash K. Cheemplavam
2004-04-15 21:56         ` Arjen Verweij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=409806C6.3060300@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=AMartin@nvidia.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ross@datscreative.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome