* Re: [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init
@ 2025-10-18 19:38 Andy Shevchenko
2025-10-22 12:54 ` Thorsten Blum
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-10-18 19:38 UTC (permalink / raw)
To: Thorsten Blum
Cc: David S. Miller, Andreas Larsson, Geert Uytterhoeven,
Helge Deller, Jens Axboe, linux-hardening, sparclinux,
linux-kernel
On Mon, Sep 22, 2025 at 11:03:52PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
>
> No functional changes intended.
Is this the only one place in floppy (arch) code?
The change itself LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init
2025-10-18 19:38 [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init Andy Shevchenko
@ 2025-10-22 12:54 ` Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-10-22 12:54 UTC (permalink / raw)
To: Andy Shevchenko
Cc: David S. Miller, Andreas Larsson, Geert Uytterhoeven,
Helge Deller, Jens Axboe, linux-hardening, sparclinux,
linux-kernel
Hi Andy,
On 18. Oct 2025, at 21:38, Andy Shevchenko wrote:
> On Mon, Sep 22, 2025 at 11:03:52PM +0200, Thorsten Blum wrote:
>> strcpy() is deprecated; use strscpy() instead.
>>
>> No functional changes intended.
>
> Is this the only one place in floppy (arch) code?
>
> The change itself LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks for the review. The whole series is already in master and removed
all strcpy() calls from arch/sparc. I'm not sure about other floppy code
elsewhere.
Best,
Thorsten
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init
2025-09-22 21:03 ` [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init Thorsten Blum
@ 2025-10-13 20:57 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2025-10-13 20:57 UTC (permalink / raw)
To: Thorsten Blum
Cc: David S. Miller, Andreas Larsson, Geert Uytterhoeven,
Helge Deller, Jens Axboe, linux-hardening, sparclinux,
linux-kernel
On Mon, Sep 22, 2025 at 11:03:52PM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
>
> No functional changes intended.
Is this the only one place in floppy (arch) code?
The change itself LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init
2025-09-22 21:03 [PATCH 1/8] sparc: PCI: Replace deprecated strcpy with strscpy Thorsten Blum
@ 2025-09-22 21:03 ` Thorsten Blum
2025-10-13 20:57 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Thorsten Blum @ 2025-09-22 21:03 UTC (permalink / raw)
To: David S. Miller, Andreas Larsson, Geert Uytterhoeven,
Helge Deller, Andy Shevchenko, Jens Axboe
Cc: linux-hardening, Thorsten Blum, sparclinux, linux-kernel
strcpy() is deprecated; use strscpy() instead.
No functional changes intended.
Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/sparc/include/asm/floppy_64.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/sparc/include/asm/floppy_64.h b/arch/sparc/include/asm/floppy_64.h
index b0f633ce3518..8d3ce6506607 100644
--- a/arch/sparc/include/asm/floppy_64.h
+++ b/arch/sparc/include/asm/floppy_64.h
@@ -13,6 +13,7 @@
#include <linux/of.h>
#include <linux/of_platform.h>
#include <linux/dma-mapping.h>
+#include <linux/string.h>
#include <asm/auxio.h>
@@ -618,7 +619,7 @@ static unsigned long __init sun_floppy_init(void)
sun_pci_fd_ebus_dma.callback = sun_pci_fd_dma_callback;
sun_pci_fd_ebus_dma.client_cookie = NULL;
sun_pci_fd_ebus_dma.irq = FLOPPY_IRQ;
- strcpy(sun_pci_fd_ebus_dma.name, "floppy");
+ strscpy(sun_pci_fd_ebus_dma.name, "floppy");
if (ebus_dma_register(&sun_pci_fd_ebus_dma))
return 0;
--
2.51.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-22 12:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-18 19:38 [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init Andy Shevchenko
2025-10-22 12:54 ` Thorsten Blum
-- strict thread matches above, loose matches on Subject: below --
2025-09-22 21:03 [PATCH 1/8] sparc: PCI: Replace deprecated strcpy with strscpy Thorsten Blum
2025-09-22 21:03 ` [PATCH 3/8] sparc: floppy: Replace deprecated strcpy with strscpy in sun_floppy_init Thorsten Blum
2025-10-13 20:57 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®