[PATCH] misc: bh1770glc: queue proximity work on freezable workqueue

[PATCH] misc: bh1770glc: queue proximity work on freezable workqueue

[Jiale Yao]

The proximity fallback work reads sensor registers after a delay. System
suspend powers the sensor down without cancelling that work, while
schedule_delayed_work() leaves it runnable on the non-freezable system
workqueue.

Queue the fallback work on system_freezable_wq so it cannot access the
powered-down sensor or its suspended I2C adapter.

Signed-off-by: Jiale Yao <yaojiale02@163.com>
---
 drivers/misc/bh1770glc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c
index 98fc5970b2bb..3411947d9283 100644
--- a/drivers/misc/bh1770glc.c
+++ b/drivers/misc/bh1770glc.c
@@ -620,8 +620,8 @@ static irqreturn_t bh1770_irq(int irq, void *data)
 		 * next expected interrupt time.
 		 */
 		cancel_delayed_work_sync(&chip->prox_work);
-		schedule_delayed_work(&chip->prox_work,
-				msecs_to_jiffies(rate + 50));
+		queue_delayed_work(system_freezable_wq, &chip->prox_work,
+				   msecs_to_jiffies(rate + 50));
 	}
 	return IRQ_HANDLED;
 }
-- 
2.34.1

Re:[PATCH] misc: bh1770glc: queue proximity work on freezable workqueue

[jiale yao]

At 2026-10-16 18:10:33, "Jiale Yao" <yaojiale02@163.com> wrote:
>The proximity fallback work reads sensor registers after a delay. System
>suspend powers the sensor down without cancelling that work, while
>schedule_delayed_work() leaves it runnable on the non-freezable system
>workqueue.
>
>Queue the fallback work on system_freezable_wq so it cannot access the
>powered-down sensor or its suspended I2C adapter.
>

Fixes: 190420ab34ab ("drivers/misc: driver for bh1770glc / sfh7770 ALS and proximity sensor")

>Signed-off-by: Jiale Yao <yaojiale02@163.com>
>---
> drivers/misc/bh1770glc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c
>index 98fc5970b2bb..3411947d9283 100644
>--- a/drivers/misc/bh1770glc.c
>+++ b/drivers/misc/bh1770glc.c
>@@ -620,8 +620,8 @@ static irqreturn_t bh1770_irq(int irq, void *data)
> 		 * next expected interrupt time.
> 		 */
> 		cancel_delayed_work_sync(&chip->prox_work);
>-		schedule_delayed_work(&chip->prox_work,
>-				msecs_to_jiffies(rate + 50));
>+		queue_delayed_work(system_freezable_wq, &chip->prox_work,
>+				   msecs_to_jiffies(rate + 50));
> 	}
> 	return IRQ_HANDLED;
> }
>-- 
>2.34.1