From: Jiri Slaby <jslaby@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] tty: amiserial.c: remove a double irq restore
Date: Thu, 4 Aug 2016 08:24:50 +0200 [thread overview]
Message-ID: <41427059-b5e4-1b30-e577-5a1cf3f81b29@suse.cz> (raw)
In-Reply-To: <20160804053403.GL775@mwanda>
On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
If I add a bit more context:
local_irq_disable();
custom.intena = IF_SETCLR | IF_TBE;
mb();
> /* set a pending Tx Interrupt, transmitter should restart now */
> custom.intreq = IF_SETCLR | IF_TBE;
> mb();
> - local_irq_restore(flags);
Really?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2016-08-04 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 5:34 Dan Carpenter
2016-08-04 6:24 ` Jiri Slaby [this message]
2016-08-04 10:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41427059-b5e4-1b30-e577-5a1cf3f81b29@suse.cz \
--to=jslaby@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®