mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, linux-integrity@vger.kernel.org
Cc: keyrings@vger.kernel.org, Vitor Soares <ivitro@gmail.com>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: Disable TCG_TPM2_HMAC by default
Date: Mon, 20 May 2024 10:50:28 -0400	[thread overview]
Message-ID: <41466b65a30a351d57869042e9f130cdb68aab5b.camel@HansenPartnership.com> (raw)
In-Reply-To: <20240518113424.13486-1-jarkko@kernel.org>

On Sat, 2024-05-18 at 14:34 +0300, Jarkko Sakkinen wrote:
> Causes performance drop in initialization so needs to be opt-in.
> Distributors are capable of opt-in enabling this. Could be also
> handled by kernel-command line in the future.
> 
> Reported-by: Vitor Soares <ivitro@gmail.com>
> Closes:
> https://lore.kernel.org/linux-integrity/bf67346ef623ff3c452c4f968b7d900911e250c3.camel@gmail.com/#t

Hey, there's no response on that thread verifying the primary
generation is the culprit.  Could we at least wait for a reply before
taking such drastic action based on surmise?

I'd be really surprised if it is primary generation.  If I used an RSA
primary it would be a problem (My oldest TPM takes a couple of minutes
to generate one) but the longest I've seen an EC primary take to
generate is still less than a second.

James


  reply	other threads:[~2024-05-20 14:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 11:34 Jarkko Sakkinen
2024-05-20 14:50 ` James Bottomley [this message]
2024-05-20 15:44   ` Jarkko Sakkinen
2025-08-14 16:22 Chris Fenner
2025-08-15 12:04 ` Jarkko Sakkinen
2025-08-15 15:45   ` Chris Fenner
2025-08-15 16:26     ` Jarkko Sakkinen
2025-08-15 17:06       ` Chris Fenner
2025-08-15 17:45         ` Jarkko Sakkinen
2025-08-15 17:52           ` Jarkko Sakkinen
2025-08-15 17:58             ` Jarkko Sakkinen
2025-08-15 18:04               ` Jarkko Sakkinen
2025-08-15 18:09                 ` Chris Fenner
2025-08-18 17:42                   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41466b65a30a351d57869042e9f130cdb68aab5b.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=ivitro@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®