From: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
To: Chris Fenner <cfenn@google.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: Disable TCG_TPM2_HMAC by default
Date: Fri, 15 Aug 2025 19:26:51 +0300 [thread overview]
Message-ID: <aJ9fy_sO6tza9qLF@iki.fi> (raw)
In-Reply-To: <CAMigqh1RTVzz0ffY8M3mZuc7NDaBKpMmCU4q0LuNyM2eAi+NFg@mail.gmail.com>
On Fri, Aug 15, 2025 at 08:45:06AM -0700, Chris Fenner wrote:
> I have a Linux machine with a standard off-the-shelf Infineon SLB9670
> TPM. Without the session salting, each PCR extension takes just 4-5
> ms. With session salting, it takes:
> * 30ms to load the null key from its context blob
> * 108ms to start the auth session and extend the PCR inside it
> * 1ms to flush the null key
>
> for an overhead of about 2880%. Depending on the configuration of the
> kernel/IMA and how many PCR measurements it's making, this could add
> up to a good chunk of time and explain reports like [3] where people
> are noting that turning this feature on adds minutes to or triples the
> boot time.
I'll with shoot another proposal. Let's delete null primary creation
code and add a parameter 'tpm.integrity_handle', which will refers to
persistent primary handle:
1. It simplifies the code considerably.
2. It makes whole a lot more sense especially given that there's
ambiguity with the key. This comes from earlier off-list
discussion where you made this argument, and I'll buy that.
I.e. even if we could certify null primary we cannot certify
it is "unambiguousness".
3. Update tpm-security documentation accordingly.
I think this might be "the long-term fix" that could be done right noW.
BR, Jarkko
next prev parent reply other threads:[~2025-08-15 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 16:22 Chris Fenner
2025-08-15 12:04 ` Jarkko Sakkinen
2025-08-15 15:45 ` Chris Fenner
2025-08-15 16:26 ` Jarkko Sakkinen [this message]
2025-08-15 17:06 ` Chris Fenner
2025-08-15 17:45 ` Jarkko Sakkinen
2025-08-15 17:52 ` Jarkko Sakkinen
2025-08-15 17:58 ` Jarkko Sakkinen
2025-08-15 18:04 ` Jarkko Sakkinen
2025-08-15 18:09 ` Chris Fenner
2025-08-18 17:42 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2024-05-18 11:34 Jarkko Sakkinen
2024-05-20 14:50 ` James Bottomley
2024-05-20 15:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJ9fy_sO6tza9qLF@iki.fi \
--to=jarkko.sakkinen@iki.fi \
--cc=cfenn@google.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®