* [PATCH v2] drm/msm: Fix GMEM_BASE on a8xx
@ 2026-10-29 23:02 Connor Abbott
2026-10-30 12:50 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Connor Abbott @ 2026-10-29 23:02 UTC (permalink / raw)
To: Nathan Chancellor, Nicolas Schier, Rob Clark, Sean Paul,
Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter
Cc: linux-kbuild, linux-kernel, linux-arm-msm, dri-devel, freedreno,
Connor Abbott
This was missed during initial bringup because GMEM_BASE is not used
anymore for textures on a8xx. However other things such as mesh shading
still use the GMEM aperture. Fix it to match the value programmed into
the registers.
Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support")
Signed-off-by: Connor Abbott <cwabbott0@gmail.com>
---
Changes in v2:
- Fix enum name
- Link to v1: https://lore.kernel.org/r/20261029-drm-msm-gmem-base-fix-v1-1-347642c5670c@gmail.com
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 5832dc25d6bf..5b05386ecffe 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -382,7 +382,9 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx,
*value = adreno_gpu->info->gmem;
return 0;
case MSM_PARAM_GMEM_BASE:
- if (adreno_gpu->info->family >= ADRENO_6XX_GEN3)
+ if (adreno_gpu->info->family >= ADRENO_8XX_GEN1)
+ *value = SZ_64M;
+ else if (adreno_gpu->info->family >= ADRENO_6XX_GEN3)
*value = 0;
else
*value = 0x100000;
---
base-commit: 9c31496a57579d0a46e1eabb8f53ec735b72d180
change-id: 20261029-drm-msm-gmem-base-fix-e1b20418ae68
Best regards,
--
Connor Abbott <cwabbott0@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/msm: Fix GMEM_BASE on a8xx
2026-10-29 23:02 [PATCH v2] drm/msm: Fix GMEM_BASE on a8xx Connor Abbott
@ 2026-10-30 12:50 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2026-10-30 12:50 UTC (permalink / raw)
To: Connor Abbott, Nathan Chancellor, Nicolas Schier, Rob Clark,
Sean Paul, Konrad Dybcio, Akhil P Oommen, Dmitry Baryshkov,
Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie,
Simona Vetter
Cc: linux-kbuild, linux-kernel, linux-arm-msm, dri-devel, freedreno
On 10/30/26 12:02 AM, Connor Abbott wrote:
> This was missed during initial bringup because GMEM_BASE is not used
> anymore for textures on a8xx. However other things such as mesh shading
> still use the GMEM aperture. Fix it to match the value programmed into
> the registers.
>
> Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support")
> Signed-off-by: Connor Abbott <cwabbott0@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-30 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 23:02 [PATCH v2] drm/msm: Fix GMEM_BASE on a8xx Connor Abbott
2026-10-30 12:50 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®