mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][2.6] Fix error path in Video4Linux dpc7146 driver
@ 2004-10-05 11:47 Michael Hunold
  0 siblings, 0 replies; only message in thread
From: Michael Hunold @ 2004-10-05 11:47 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Andrew Morton, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi,

this patch fixes an error path in my dpc7146 Video4Linux driver.

The I2C adapter wasn't de-registered correctly in case the video card 
wasn't found. When the I2C subsystem tried to speak with the dangling 
I2C adapter later on, usually an oops happened.

Please apply.

Regards
Michael Hunold.

[-- Attachment #2: v4l_dpc7146_fix.diff --]
[-- Type: text/plain, Size: 478 bytes --]

diff -ura linux-2.6.9-rc3/drivers/media/video/dpc7146.c b/drivers/media/video/dpc7146.c
--- linux-2.6.9-rc3/drivers/media/video/dpc7146.c	2004-10-05 13:34:45.000000000 +0200
+++ b/drivers/media/video/dpc7146.c	2004-10-05 13:40:54.000000000 +0200
@@ -123,6 +123,7 @@
 	/* check if all devices are present */
 	if( 0 == dpc->saa7111a ) {
 		DEB_D(("dpc_v4l2.o: dpc_attach failed for this device.\n"));	
+		i2c_del_adapter(&dpc->i2c_adapter);
 		kfree(dpc);
 		return -ENODEV;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-10-05 11:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-05 11:47 [PATCH][2.6] Fix error path in Video4Linux dpc7146 driver Michael Hunold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome