From: Oleg Nesterov <oleg@tv-sign.ru>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>
Subject: BUG? nosmp and pcibios_fixup_irqs()
Date: Sun, 10 Oct 2004 19:27:16 +0400 [thread overview]
Message-ID: <416954D4.956AA617@tv-sign.ru> (raw)
Hello.
void smp_boot_cpus(unsigned int max_cpus)
{
if (!max_cpus) {
smpboot_clear_io_apic_irqs();
// sets io_apic_irqs = 0;
return;
}
setup_IO_APIC();
}
void pcibios_fixup_irqs(void)
{
while (dev = pci_find_device())
if (io_apic_assign_pci_irqs)
dev->irq = IO_APIC_get_PCI_irq_vector();
}
It seems to me that this dev->irq assignment is wrong in case
when setup_IO_APIC() was not called, and this is the case for
'nosmp' parameter.
With this change:
- if (io_apic_assign_pci_irqs)
+ if (io_apic_assign_pci_irqs && io_apic_irqs)
my netwok card works with nosmp, but i never looked in
arch/i386/pci/ before, so i am probably wrong.
Or nosmp does not make sense without noapic?
Oleg.
reply other threads:[~2004-10-10 15:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416954D4.956AA617@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®