* BUG? nosmp and pcibios_fixup_irqs()
@ 2004-10-10 15:27 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2004-10-10 15:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar
Hello.
void smp_boot_cpus(unsigned int max_cpus)
{
if (!max_cpus) {
smpboot_clear_io_apic_irqs();
// sets io_apic_irqs = 0;
return;
}
setup_IO_APIC();
}
void pcibios_fixup_irqs(void)
{
while (dev = pci_find_device())
if (io_apic_assign_pci_irqs)
dev->irq = IO_APIC_get_PCI_irq_vector();
}
It seems to me that this dev->irq assignment is wrong in case
when setup_IO_APIC() was not called, and this is the case for
'nosmp' parameter.
With this change:
- if (io_apic_assign_pci_irqs)
+ if (io_apic_assign_pci_irqs && io_apic_irqs)
my netwok card works with nosmp, but i never looked in
arch/i386/pci/ before, so i am probably wrong.
Or nosmp does not make sense without noapic?
Oleg.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-10-10 15:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-10 15:27 BUG? nosmp and pcibios_fixup_irqs() Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®