* [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
@ 2022-09-01 14:15 Hamza Mahfooz
2022-09-01 15:47 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 2+ messages in thread
From: Hamza Mahfooz @ 2022-09-01 14:15 UTC (permalink / raw)
To: linux-kernel
Cc: Hamza Mahfooz, Harry Wentland, Leo Li, Rodrigo Siqueira,
Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Nicholas Kazlauskas, Jun Lei,
Meenakshikumar Somasundaram, Alvin Lee, Martin Leung, Samson Tam,
Alex Hung, Wenjing Liu, Joshua Aberback, amd-gfx, dri-devel
Address the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
3508 | if (update_type != UPDATE_TYPE_FAST)
| ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
3510 | if (update_type != UPDATE_TYPE_FAST)
| ^~
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
v2: implement feedback from Alvin
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index b49237390cce..9860bf38c547 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
if (update_type != UPDATE_TYPE_FAST)
dc->hwss.post_unlock_program_front_end(dc, context);
- if (update_type != UPDATE_TYPE_FAST)
- if (dc->hwss.commit_subvp_config)
- dc->hwss.commit_subvp_config(dc, context);
+
+ if (update_type != UPDATE_TYPE_FAST)
+ if (dc->hwss.commit_subvp_config)
+ dc->hwss.commit_subvp_config(dc, context);
/* Since phantom pipe programming is moved to post_unlock_program_front_end,
* move the SubVP lock to after the phantom pipes have been setup
--
2.37.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()
2022-09-01 14:15 [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream() Hamza Mahfooz
@ 2022-09-01 15:47 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-01 15:47 UTC (permalink / raw)
To: Hamza Mahfooz, linux-kernel
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König, Pan,
Xinhui, David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Jun Lei, Meenakshikumar Somasundaram, Alvin Lee, Martin Leung,
Samson Tam, Alex Hung, Wenjing Liu, Joshua Aberback, amd-gfx,
dri-devel
On 2022-09-01 10:15, Hamza Mahfooz wrote:
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
> 3508 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
> 3510 | if (update_type != UPDATE_TYPE_FAST)
> | ^~
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
> v2: implement feedback from Alvin
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..9860bf38c547 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
>
> if (update_type != UPDATE_TYPE_FAST)
> dc->hwss.post_unlock_program_front_end(dc, context);
> - if (update_type != UPDATE_TYPE_FAST)
> - if (dc->hwss.commit_subvp_config)
> - dc->hwss.commit_subvp_config(dc, context);
> +
> + if (update_type != UPDATE_TYPE_FAST)
> + if (dc->hwss.commit_subvp_config)
> + dc->hwss.commit_subvp_config(dc, context);
>
> /* Since phantom pipe programming is moved to post_unlock_program_front_end,
> * move the SubVP lock to after the phantom pipes have been setup
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-01 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 14:15 [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream() Hamza Mahfooz
2022-09-01 15:47 ` Rodrigo Siqueira Jordao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®