* [PATCH] don't hide thread_group_leader() from grep
@ 2004-11-09 16:50 Oleg Nesterov
2004-11-09 17:00 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2004-11-09 16:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, Andrew Morton
Trivial. replace open-coded thread_group_leader() calls.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.10-rc1/fs/binfmt_elf.c~ 2004-11-08 19:43:28.000000000 +0300
+++ 2.6.10-rc1/fs/binfmt_elf.c 2004-11-09 21:32:09.331095272 +0300
@@ -1181,7 +1181,7 @@ static void fill_prstatus(struct elf_prs
prstatus->pr_ppid = p->parent->pid;
prstatus->pr_pgrp = process_group(p);
prstatus->pr_sid = p->signal->session;
- if (p->pid == p->tgid) {
+ if (thread_group_leader(p)) {
/*
* This is the record for the group leader. Add in the
* cumulative times of previous dead threads. This total
--- 2.6.10-rc1/fs/exec.c~ 2004-11-08 19:43:29.000000000 +0300
+++ 2.6.10-rc1/fs/exec.c 2004-11-09 22:10:56.767271192 +0300
@@ -605,7 +605,7 @@ static inline int de_thread(struct task_
* Account for the thread group leader hanging around:
*/
count = 2;
- if (current->pid == current->tgid)
+ if (thread_group_leader(current))
count = 1;
while (atomic_read(&sig->count) > count) {
sig->group_exit_task = current;
@@ -624,7 +624,7 @@ static inline int de_thread(struct task_
* do is to wait for the thread group leader to become inactive,
* and to assume its PID:
*/
- if (current->pid != current->tgid) {
+ if (!thread_group_leader(current)) {
struct task_struct *leader = current->group_leader, *parent;
struct dentry *proc_dentry1, *proc_dentry2;
unsigned long exit_state, ptrace;
@@ -734,7 +734,7 @@ no_thread_group:
if (!thread_group_empty(current))
BUG();
- if (current->tgid != current->pid)
+ if (!thread_group_leader(current))
BUG();
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] don't hide thread_group_leader() from grep
2004-11-09 16:50 [PATCH] don't hide thread_group_leader() from grep Oleg Nesterov
@ 2004-11-09 17:00 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2004-11-09 17:00 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: linux-kernel, Andrew Morton
* Oleg Nesterov <oleg@tv-sign.ru> wrote:
> Trivial. replace open-coded thread_group_leader() calls.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-09 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-09 16:50 [PATCH] don't hide thread_group_leader() from grep Oleg Nesterov
2004-11-09 17:00 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®