mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net v2 0/2] ionic: fix Tx stalls on TSO skbs larger than the Tx ring
@ 2026-11-17 19:18 Nikhil P. Rao
  2026-11-17 19:18 ` [PATCH net v2 1/2] ionic: reject Tx ring sizes below the minimum Nikhil P. Rao
  2026-11-17 19:18 ` [PATCH net v2 2/2] ionic: limit TSO segments to the minimum Tx ring size Nikhil P. Rao
  0 siblings, 2 replies; 4+ messages in thread
From: Nikhil P. Rao @ 2026-11-17 19:18 UTC (permalink / raw)
  To: Brett Creeley, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel, Breno Leitao, Eric Joyner,
	Abhijit Gangurde, stable, Nikhil P. Rao

ionic uses one Tx descriptor per TSO segment but never sets
tso_max_segs, so the stack can build TSO skbs with more segments than
the Tx ring holds. Such an skb can never be posted: the queue stops,
nothing wakes it, and the netdev watchdog fires. Guest TCP traffic with
an MSS below 64 hit this on the default 1024-entry ring.

Patch 1 rejects Tx ring sizes below 64. The completion path wakes a
stopped Tx queue only once 44 descriptors are free, so a smaller ring
never wakes once stopped.

Patch 2 raises the minimum Tx ring size to 128 and sets tso_max_segs
to 127, so every Tx ring can hold the largest TSO skb and larger GSO
skbs are segmented in software.

The two patches fix separate bugs; patch 2 raises the Tx ring minimum
that patch 1 adds from 64 to 128.

Changes in v2:
- Patch 2: use a fixed limit of 127 segments and a 128-entry minimum
  Tx ring instead of following the Tx ring size, as suggested by Jakub.
  This also covers the hwstamp and kdump Tx rings.
- Add testing notes to both patches, and Cc stable.
- Link to v1: https://lore.kernel.org/all/20261107-b4-ionic-tso-max-segs-v1-0-67c248a5b681@amd.com/

This series was developed with the help of an LLM-based coding
assistant (Claude).

---
Nikhil P. Rao (2):
      ionic: reject Tx ring sizes below the minimum
      ionic: limit TSO segments to the minimum Tx ring size

 drivers/net/ethernet/pensando/ionic/ionic_dev.h     |  3 ++-
 drivers/net/ethernet/pensando/ionic/ionic_ethtool.c |  7 +++++++
 drivers/net/ethernet/pensando/ionic/ionic_lif.c     | 10 ++++++----
 3 files changed, 15 insertions(+), 5 deletions(-)
---
base-commit: a2fd526d644233d6a892c28173f07c61e21e4c93
change-id: 20261107-b4-ionic-tso-max-segs-057bde9cfe49

Best regards,
--  
Nikhil P. Rao <nikhil.rao@amd.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-20 19:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 19:18 [PATCH net v2 0/2] ionic: fix Tx stalls on TSO skbs larger than the Tx ring Nikhil P. Rao
2026-11-17 19:18 ` [PATCH net v2 1/2] ionic: reject Tx ring sizes below the minimum Nikhil P. Rao
2026-11-17 19:18 ` [PATCH net v2 2/2] ionic: limit TSO segments to the minimum Tx ring size Nikhil P. Rao
2026-11-20 19:58   ` Rao, Nikhil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®