* [PATCH] drm/amd: open brace '{' following struct go on the same line [not found] <20230714062152.13738-1-xujianghui@cdjrlc.com> @ 2023-07-14 6:23 ` sunran001 0 siblings, 0 replies; 5+ messages in thread From: sunran001 @ 2023-07-14 6:23 UTC (permalink / raw) To: airlied, daniel; +Cc: amd-gfx, dri-devel, linux-kernel Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun <sunran001@208suo.com> --- drivers/gpu/drm/amd/include/atomfirmwareid.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atomfirmwareid.h b/drivers/gpu/drm/amd/include/atomfirmwareid.h index e6256efd03ae..1ca5fe7b131b 100644 --- a/drivers/gpu/drm/amd/include/atomfirmwareid.h +++ b/drivers/gpu/drm/amd/include/atomfirmwareid.h @@ -28,8 +28,7 @@ #ifndef _ATOMFIRMWAREID_H_ #define _ATOMFIRMWAREID_H_ -enum atom_master_data_table_id -{ +enum atom_master_data_table_id { VBIOS_DATA_TBL_ID__UTILITY_PIPELINE, VBIOS_DATA_TBL_ID__MULTIMEDIA_INF, VBIOS_DATA_TBL_ID__FIRMWARE_INF, @@ -51,8 +50,7 @@ enum atom_master_data_table_id VBIOS_DATA_TBL_ID__UNDEFINED, }; -enum atom_master_command_table_id -{ +enum atom_master_command_table_id { VBIOS_CMD_TBL_ID__ASIC_INIT, VBIOS_CMD_TBL_ID__DIGX_ENCODER_CONTROL, VBIOS_CMD_TBL_ID__SET_ENGINE_CLOCK, ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20230721012635.4552-1-xujianghui@cdjrlc.com>]
* [PATCH] drm/amd: open brace '{' following struct go on the same line [not found] <20230721012635.4552-1-xujianghui@cdjrlc.com> @ 2023-07-21 1:31 ` sunran001 2023-07-21 15:55 ` Alex Deucher 0 siblings, 1 reply; 5+ messages in thread From: sunran001 @ 2023-07-21 1:31 UTC (permalink / raw) To: alexander.deucher, airlied, daniel; +Cc: amd-gfx, dri-devel, linux-kernel Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun <sunran001@208suo.com> --- drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h b/drivers/gpu/drm/amd/include/yellow_carp_offset.h index 0fea6a746611..a2c8dca2425e 100644 --- a/drivers/gpu/drm/amd/include/yellow_carp_offset.h +++ b/drivers/gpu/drm/amd/include/yellow_carp_offset.h @@ -7,13 +7,11 @@ #define MAX_SEGMENT 6 -struct IP_BASE_INSTANCE -{ +struct IP_BASE_INSTANCE { unsigned int segment[MAX_SEGMENT]; } __maybe_unused; -struct IP_BASE -{ +struct IP_BASE { struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; } __maybe_unused; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd: open brace '{' following struct go on the same line 2023-07-21 1:31 ` sunran001 @ 2023-07-21 15:55 ` Alex Deucher 0 siblings, 0 replies; 5+ messages in thread From: Alex Deucher @ 2023-07-21 15:55 UTC (permalink / raw) To: sunran001 Cc: alexander.deucher, airlied, daniel, dri-devel, amd-gfx, linux-kernel On Thu, Jul 20, 2023 at 9:31 PM <sunran001@208suo.com> wrote: > > Fix the checkpatch error as open brace '{' following struct should > go on the same line. > > Signed-off-by: Ran Sun <sunran001@208suo.com> git am didn't seem to like the patch, but I was able to apply it cleanly manually with no fuzz. Not sure what's up, but I've applied it. Alex > --- > drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h > b/drivers/gpu/drm/amd/include/yellow_carp_offset.h > index 0fea6a746611..a2c8dca2425e 100644 > --- a/drivers/gpu/drm/amd/include/yellow_carp_offset.h > +++ b/drivers/gpu/drm/amd/include/yellow_carp_offset.h > @@ -7,13 +7,11 @@ > #define MAX_SEGMENT 6 > > > -struct IP_BASE_INSTANCE > -{ > +struct IP_BASE_INSTANCE { > unsigned int segment[MAX_SEGMENT]; > } __maybe_unused; > > -struct IP_BASE > -{ > +struct IP_BASE { > struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; > } __maybe_unused; ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20230714060105.13377-1-xujianghui@cdjrlc.com>]
* [PATCH] drm/amd: open brace '{' following struct go on the same line [not found] <20230714060105.13377-1-xujianghui@cdjrlc.com> @ 2023-07-14 6:04 ` sunran001 2023-07-18 14:34 ` Alex Deucher 0 siblings, 1 reply; 5+ messages in thread From: sunran001 @ 2023-07-14 6:04 UTC (permalink / raw) To: airlied, daniel; +Cc: amd-gfx, dri-devel, linux-kernel Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun <sunran001@208suo.com> --- drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h b/drivers/gpu/drm/amd/include/yellow_carp_offset.h index 0fea6a746611..a2c8dca2425e 100644 --- a/drivers/gpu/drm/amd/include/yellow_carp_offset.h +++ b/drivers/gpu/drm/amd/include/yellow_carp_offset.h @@ -7,13 +7,11 @@ #define MAX_SEGMENT 6 -struct IP_BASE_INSTANCE -{ +struct IP_BASE_INSTANCE { unsigned int segment[MAX_SEGMENT]; } __maybe_unused; -struct IP_BASE -{ +struct IP_BASE { struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; } __maybe_unused; ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd: open brace '{' following struct go on the same line 2023-07-14 6:04 ` sunran001 @ 2023-07-18 14:34 ` Alex Deucher 0 siblings, 0 replies; 5+ messages in thread From: Alex Deucher @ 2023-07-18 14:34 UTC (permalink / raw) To: sunran001; +Cc: airlied, daniel, dri-devel, amd-gfx, linux-kernel I'm happy to apply these patches, but please check your mailer. The formatting is messed up and they don't apply cleanly. Please use git-format-patch and git-send-email to generate and send the patches. Thanks! Alex On Fri, Jul 14, 2023 at 2:04 AM <sunran001@208suo.com> wrote: > > Fix the checkpatch error as open brace '{' following struct should > go on the same line. > > Signed-off-by: Ran Sun <sunran001@208suo.com> > --- > drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h > b/drivers/gpu/drm/amd/include/yellow_carp_offset.h > index 0fea6a746611..a2c8dca2425e 100644 > --- a/drivers/gpu/drm/amd/include/yellow_carp_offset.h > +++ b/drivers/gpu/drm/amd/include/yellow_carp_offset.h > @@ -7,13 +7,11 @@ > #define MAX_SEGMENT 6 > > -struct IP_BASE_INSTANCE > -{ > +struct IP_BASE_INSTANCE { > unsigned int segment[MAX_SEGMENT]; > } __maybe_unused; > > -struct IP_BASE > -{ > +struct IP_BASE { > struct IP_BASE_INSTANCE instance[MAX_INSTANCE]; > } __maybe_unused; ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-21 15:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230714062152.13738-1-xujianghui@cdjrlc.com>
2023-07-14 6:23 ` [PATCH] drm/amd: open brace '{' following struct go on the same line sunran001
[not found] <20230721012635.4552-1-xujianghui@cdjrlc.com>
2023-07-21 1:31 ` sunran001
2023-07-21 15:55 ` Alex Deucher
[not found] <20230714060105.13377-1-xujianghui@cdjrlc.com>
2023-07-14 6:04 ` sunran001
2023-07-18 14:34 ` Alex Deucher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®