* [PATCH 1/2] net: enc28j60: support getting irq number from gpio phandle in the device tree
@ 2025-03-09 7:47 Hanyuan Zhao
2025-03-09 15:41 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Hanyuan Zhao @ 2025-03-09 7:47 UTC (permalink / raw)
To: davem, kuba, andrew+netdev, edumazet, pabeni
Cc: netdev, linux-kernel, Hanyuan Zhao
This patch allows the kernel to automatically requests the pin, configures
it as an input, and converts it to an IRQ number, according to a GPIO
phandle specified in device tree. This simplifies the process by
eliminating the need to manually define pinctrl and interrupt nodes.
Additionally, it is necessary for platforms that do not support pin
configuration and properties via the device tree.
Signed-off-by: Hanyuan Zhao <hanyuan-z@qq.com>
---
drivers/net/ethernet/microchip/enc28j60.c | 25 ++++++++++++++++++-----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c
index d6c9491537e4..b3613e45c900 100644
--- a/drivers/net/ethernet/microchip/enc28j60.c
+++ b/drivers/net/ethernet/microchip/enc28j60.c
@@ -24,6 +24,7 @@
#include <linux/skbuff.h>
#include <linux/delay.h>
#include <linux/spi/spi.h>
+#include <linux/of_gpio.h>
#include "enc28j60_hw.h"
@@ -1526,6 +1527,7 @@ static int enc28j60_probe(struct spi_device *spi)
struct net_device *dev;
struct enc28j60_net *priv;
int ret = 0;
+ unsigned long irq_flags = IRQF_ONESHOT;
if (netif_msg_drv(&debug))
dev_info(&spi->dev, "Ethernet driver %s loaded\n", DRV_VERSION);
@@ -1558,20 +1560,33 @@ static int enc28j60_probe(struct spi_device *spi)
eth_hw_addr_random(dev);
enc28j60_set_hw_macaddr(dev);
+ if (spi->irq > 0) {
+ dev->irq = spi->irq;
+ } else {
+ /* Try loading device tree property irq-gpios */
+ struct gpio_desc *irq_gpio_desc = devm_fwnode_gpiod_get_index(&spi->dev,
+ of_fwnode_handle(spi->dev.of_node), "irq", 0, GPIOD_IN, NULL);
+ if (IS_ERR(irq_gpio_desc)) {
+ dev_err(&spi->dev, "unable to get a valid irq gpio\n");
+ goto error_irq;
+ }
+ dev->irq = gpiod_to_irq(irq_gpio_desc);
+ irq_flags |= IRQF_TRIGGER_FALLING;
+ }
+
/* Board setup must set the relevant edge trigger type;
* level triggers won't currently work.
*/
- ret = request_threaded_irq(spi->irq, NULL, enc28j60_irq, IRQF_ONESHOT,
+ ret = request_threaded_irq(dev->irq, NULL, enc28j60_irq, irq_flags,
DRV_NAME, priv);
if (ret < 0) {
if (netif_msg_probe(priv))
dev_err(&spi->dev, "request irq %d failed (ret = %d)\n",
- spi->irq, ret);
+ dev->irq, ret);
goto error_irq;
}
dev->if_port = IF_PORT_10BASET;
- dev->irq = spi->irq;
dev->netdev_ops = &enc28j60_netdev_ops;
dev->watchdog_timeo = TX_TIMEOUT;
dev->ethtool_ops = &enc28j60_ethtool_ops;
@@ -1589,7 +1604,7 @@ static int enc28j60_probe(struct spi_device *spi)
return 0;
error_register:
- free_irq(spi->irq, priv);
+ free_irq(dev->irq, priv);
error_irq:
free_netdev(dev);
error_alloc:
@@ -1601,7 +1616,7 @@ static void enc28j60_remove(struct spi_device *spi)
struct enc28j60_net *priv = spi_get_drvdata(spi);
unregister_netdev(priv->netdev);
- free_irq(spi->irq, priv);
+ free_irq(priv->netdev->irq, priv);
free_netdev(priv->netdev);
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] net: enc28j60: support getting irq number from gpio phandle in the device tree
2025-03-09 7:47 [PATCH 1/2] net: enc28j60: support getting irq number from gpio phandle in the device tree Hanyuan Zhao
@ 2025-03-09 15:41 ` Andrew Lunn
[not found] ` <tencent_BE0060E3A7AF384BAF4DA37FD2121B8E1D07@qq.com>
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2025-03-09 15:41 UTC (permalink / raw)
To: Hanyuan Zhao
Cc: davem, kuba, andrew+netdev, edumazet, pabeni, netdev, linux-kernel
On Sun, Mar 09, 2025 at 03:47:08PM +0800, Hanyuan Zhao wrote:
> This patch allows the kernel to automatically requests the pin, configures
> it as an input, and converts it to an IRQ number, according to a GPIO
> phandle specified in device tree. This simplifies the process by
> eliminating the need to manually define pinctrl and interrupt nodes.
> Additionally, it is necessary for platforms that do not support pin
> configuration and properties via the device tree.
>
> Signed-off-by: Hanyuan Zhao <hanyuan-z@qq.com>
> ---
> drivers/net/ethernet/microchip/enc28j60.c | 25 ++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c
> index d6c9491537e4..b3613e45c900 100644
> --- a/drivers/net/ethernet/microchip/enc28j60.c
> +++ b/drivers/net/ethernet/microchip/enc28j60.c
> @@ -24,6 +24,7 @@
> #include <linux/skbuff.h>
> #include <linux/delay.h>
> #include <linux/spi/spi.h>
> +#include <linux/of_gpio.h>
>
> #include "enc28j60_hw.h"
>
> @@ -1526,6 +1527,7 @@ static int enc28j60_probe(struct spi_device *spi)
> struct net_device *dev;
> struct enc28j60_net *priv;
> int ret = 0;
> + unsigned long irq_flags = IRQF_ONESHOT;
>
> if (netif_msg_drv(&debug))
> dev_info(&spi->dev, "Ethernet driver %s loaded\n", DRV_VERSION);
> @@ -1558,20 +1560,33 @@ static int enc28j60_probe(struct spi_device *spi)
> eth_hw_addr_random(dev);
> enc28j60_set_hw_macaddr(dev);
>
> + if (spi->irq > 0) {
> + dev->irq = spi->irq;
> + } else {
> + /* Try loading device tree property irq-gpios */
> + struct gpio_desc *irq_gpio_desc = devm_fwnode_gpiod_get_index(&spi->dev,
> + of_fwnode_handle(spi->dev.of_node), "irq", 0, GPIOD_IN, NULL);
> + if (IS_ERR(irq_gpio_desc)) {
> + dev_err(&spi->dev, "unable to get a valid irq gpio\n");
> + goto error_irq;
> + }
> + dev->irq = gpiod_to_irq(irq_gpio_desc);
My understanding is that you should not need most of this. The IRQ
core will handle converting a GPIO to an interrupt, if you just list
is as an interrupt source in the normal way.
> + irq_flags |= IRQF_TRIGGER_FALLING;
You say:
> Additionally, it is necessary for platforms that do not support pin
> configuration and properties via the device tree.
Are you talking about ACPI?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] net: enc28j60: support getting irq number from gpiophandle in the device tree
[not found] ` <tencent_BE0060E3A7AF384BAF4DA37FD2121B8E1D07@qq.com>
@ 2025-03-10 12:06 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2025-03-10 12:06 UTC (permalink / raw)
To: hanyuan-z
Cc: davem, kuba, andrew+netdev, edumazet, pabeni, netdev, linux-kernel
On Mon, Mar 10, 2025 at 10:20:01AM +0800, hanyuan-z wrote:
> Hi Andrew, <br/><br/>> My understanding is that you should not need most of this. The IRQ<br/>> core will handle converting a GPIO to an interrupt, if you just list<br/>> is as an interrupt source in the normal way.<br/><br/>> You say:<br/>><br/>> > Additionally, it is necessary for platforms that do not support pin<br/>> > configuration and properties via the device tree.<br/>><br/>> Are you talking about ACPI?<br/><br/>Thanks for your review. Let me explain them.<br/><br/>I understand that specifying the interrupt as:<br/><br/> interrupts = <&gpio2 23 IRQ_TYPE_LEVEL_LOW>;<br/><br/>would also work, and the IRQ subsystem will properly handle the<br/>conversion during the SPI probe. However, my problem is that the<br/>GPIO pin itself needs to be explicitly requested and configured a<br/>an input before it can be used as an IRQ pin.<br/><br/>My embedded platform has limited support, it only provides a<br/>hard-coded pin control driver and does not support configuring<br/>pinctrl properties in the device tree. So, there is no generic<br/>way to request the pin and set its direction via device tree bindings.<br/><br/>I noticed that some existing NIC drivers solve this issue by specifying<br/>`irq-gpios` in the device tree, which ensures that the GPIO is properly<br/>initialized before being converted to an IRQ.<br/><br/>That was my motivation for these patches.<br/><br/>And my changes are not related to ACPI in any way—they are mainly<br/>focused on device tree handling.<br/><br/>Thanks, <br/>Hanyuan Zhao <br/>
Please use plain text for emails.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-10 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-09 7:47 [PATCH 1/2] net: enc28j60: support getting irq number from gpio phandle in the device tree Hanyuan Zhao
2025-03-09 15:41 ` Andrew Lunn
[not found] ` <tencent_BE0060E3A7AF384BAF4DA37FD2121B8E1D07@qq.com>
2025-03-10 12:06 ` [PATCH 1/2] net: enc28j60: support getting irq number from gpiophandle " Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®