* [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function
@ 2025-03-05 14:09 Dario Binacchi
2025-03-12 8:17 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Dario Binacchi @ 2025-03-05 14:09 UTC (permalink / raw)
To: linux-kernel
Cc: linux-amarula, Dario Binacchi, Michael Trimarchi,
Thomas Zimmermann, David Airlie, Fabio Estevam,
Maarten Lankhorst, Marek Vasut, Maxime Ripard,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Simona Vetter,
Stefan Agner, dri-devel, imx, linux-arm-kernel
Use aperture helpers to remove all generic graphics drivers before
loading mxsfb. Makes mxsfb compatible with simpledrm.
Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
Changes in v3:
- Add 'Reviewed-by' of Thomas Zimmermann
Changes in v2:
- Use aperture_remove_all_conflicting_devices() instead of
drm_aperture_remove_framebuffers().
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 59020862cf65..e5eb644b54ae 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -8,6 +8,7 @@
* Copyright (C) 2008 Embedded Alley Solutions, Inc All Rights Reserved.
*/
+#include <linux/aperture.h>
#include <linux/clk.h>
#include <linux/dma-mapping.h>
#include <linux/io.h>
@@ -361,6 +362,15 @@ static int mxsfb_probe(struct platform_device *pdev)
if (ret)
goto err_free;
+ /*
+ * Remove early framebuffers (ie. simplefb). The framebuffer can be
+ * located anywhere in RAM
+ */
+ ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name);
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret,
+ "can't kick out existing framebuffers\n");
+
ret = drm_dev_register(drm, 0);
if (ret)
goto err_unload;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function
2025-03-05 14:09 [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function Dario Binacchi
@ 2025-03-12 8:17 ` Thomas Zimmermann
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2025-03-12 8:17 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: linux-amarula, Michael Trimarchi, David Airlie, Fabio Estevam,
Maarten Lankhorst, Marek Vasut, Maxime Ripard,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Simona Vetter,
Stefan Agner, dri-devel, imx, linux-arm-kernel
Merged into drm-misc-next. Thanks for the patch.
Am 05.03.25 um 15:09 schrieb Dario Binacchi:
> Use aperture helpers to remove all generic graphics drivers before
> loading mxsfb. Makes mxsfb compatible with simpledrm.
>
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> ---
>
> Changes in v3:
> - Add 'Reviewed-by' of Thomas Zimmermann
>
> Changes in v2:
> - Use aperture_remove_all_conflicting_devices() instead of
> drm_aperture_remove_framebuffers().
>
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 59020862cf65..e5eb644b54ae 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -8,6 +8,7 @@
> * Copyright (C) 2008 Embedded Alley Solutions, Inc All Rights Reserved.
> */
>
> +#include <linux/aperture.h>
> #include <linux/clk.h>
> #include <linux/dma-mapping.h>
> #include <linux/io.h>
> @@ -361,6 +362,15 @@ static int mxsfb_probe(struct platform_device *pdev)
> if (ret)
> goto err_free;
>
> + /*
> + * Remove early framebuffers (ie. simplefb). The framebuffer can be
> + * located anywhere in RAM
> + */
> + ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret,
> + "can't kick out existing framebuffers\n");
> +
> ret = drm_dev_register(drm, 0);
> if (ret)
> goto err_unload;
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function
@ 2025-02-14 15:05 Dario Binacchi
0 siblings, 0 replies; 3+ messages in thread
From: Dario Binacchi @ 2025-02-14 15:05 UTC (permalink / raw)
To: linux-kernel
Cc: linux-amarula, Dario Binacchi, Michael Trimarchi,
Thomas Zimmermann, David Airlie, Fabio Estevam,
Maarten Lankhorst, Marek Vasut, Maxime Ripard,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo, Simona Vetter,
Stefan Agner, dri-devel, imx, linux-arm-kernel
Use aperture helpers to remove all generic graphics drivers before
loading mxsfb. Makes mxsfb compatible with simpledrm.
Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
Changes in v3:
- Add 'Reviewed-by' of Thomas Zimmermann
Changes in v2:
- Use aperture_remove_all_conflicting_devices() instead of
drm_aperture_remove_framebuffers().
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 59020862cf65..e5eb644b54ae 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -8,6 +8,7 @@
* Copyright (C) 2008 Embedded Alley Solutions, Inc All Rights Reserved.
*/
+#include <linux/aperture.h>
#include <linux/clk.h>
#include <linux/dma-mapping.h>
#include <linux/io.h>
@@ -361,6 +362,15 @@ static int mxsfb_probe(struct platform_device *pdev)
if (ret)
goto err_free;
+ /*
+ * Remove early framebuffers (ie. simplefb). The framebuffer can be
+ * located anywhere in RAM
+ */
+ ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name);
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret,
+ "can't kick out existing framebuffers\n");
+
ret = drm_dev_register(drm, 0);
if (ret)
goto err_unload;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-12 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-05 14:09 [RESEND PATCH v3] drm/mxsfb: Remove generic DRM drivers in probe function Dario Binacchi
2025-03-12 8:17 ` Thomas Zimmermann
-- strict thread matches above, loose matches on Subject: below --
2025-02-14 15:05 Dario Binacchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®