* [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD
@ 2020-01-22 7:16 Hongbo Yao
2020-01-22 9:04 ` Thomas, Rijo-john
0 siblings, 1 reply; 2+ messages in thread
From: Hongbo Yao @ 2020-01-22 7:16 UTC (permalink / raw)
To: jens.wiklander, Rijo-john.Thomas
Cc: yaohongbo, chenzhou10, tee-dev, linux-kernel
If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
while building call.c or core.c
drivers/tee/amdtee/call.o: In function `handle_unload_ta':
call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status
Fix the config dependency for AMDTEE here.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
---
drivers/tee/amdtee/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
index 4e32b6413b41..191f9715fa9a 100644
--- a/drivers/tee/amdtee/Kconfig
+++ b/drivers/tee/amdtee/Kconfig
@@ -3,6 +3,6 @@
config AMDTEE
tristate "AMD-TEE"
default m
- depends on CRYPTO_DEV_SP_PSP
+ depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
help
This implements AMD's Trusted Execution Environment (TEE) driver.
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD
2020-01-22 7:16 [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD Hongbo Yao
@ 2020-01-22 9:04 ` Thomas, Rijo-john
0 siblings, 0 replies; 2+ messages in thread
From: Thomas, Rijo-john @ 2020-01-22 9:04 UTC (permalink / raw)
To: Hongbo Yao, jens.wiklander
Cc: chenzhou10, tee-dev, linux-kernel, Herbert Xu, Rangasamy, Devaraj
+Deva, Herbert
Hi Hongbo,
On 22/01/20 12:46 pm, Hongbo Yao wrote:
> If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
> while building call.c or core.c
>
> drivers/tee/amdtee/call.o: In function `handle_unload_ta':
> call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
> drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
> core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status
>
> Fix the config dependency for AMDTEE here.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
You may have to resubmit this patch to linux-crypto list, so that it shows
up in patchwork and applied to cryptodev-2.6 tree
Thanks,
Rijo
> ---
> drivers/tee/amdtee/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
> index 4e32b6413b41..191f9715fa9a 100644
> --- a/drivers/tee/amdtee/Kconfig
> +++ b/drivers/tee/amdtee/Kconfig
> @@ -3,6 +3,6 @@
> config AMDTEE
> tristate "AMD-TEE"
> default m
> - depends on CRYPTO_DEV_SP_PSP
> + depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
> help
> This implements AMD's Trusted Execution Environment (TEE) driver.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 7:16 [PATCH -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD Hongbo Yao
2020-01-22 9:04 ` Thomas, Rijo-john
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®