mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Xu Liang <lxu@maxlinear.com>
Subject: Re: [PATCH] net: phy: add driver for MaxLinear MxL86110 PHY
Date: Thu, 15 May 2025 18:36:39 +0200	[thread overview]
Message-ID: <4249b016-34c3-4afc-831a-96ba61c3ffce@lunn.ch> (raw)
In-Reply-To: <20250515152432.77835-1-stefano.radaelli21@gmail.com>

> +/* delay can be adjusted in steps of about 150ps */
> +#define MXL86110_EXT_RGMII_CFG1_RX_NO_DELAY				(0x0 << 10)
> +#define MXL86110_EXT_RGMII_CFG1_RX_DELAY_2250PS				(0xF << 10)

If the steps are 150ps, what you actually want is
#define MXL86110_EXT_RGMII_CFG1_RX_DELAY_1950PS				(13 << 10)

since this is the closest you can get to 2000ps.

> +#define MXL86110_EXT_RGMII_CFG1_RX_DELAY_150PS				(0x1 << 10)

And there should not be any need for this. Delays are either 0ps or
2000ps for the different RGMII modes.

       Andrew

  parent reply	other threads:[~2025-05-15 16:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 15:24 Stefano Radaelli
2025-05-15 16:33 ` Andrew Lunn
2025-05-15 17:23   ` Stefano Radaelli
2025-05-15 17:54     ` Andrew Lunn
2025-05-15 16:36 ` Andrew Lunn [this message]
2025-05-15 18:48 Stefano Radaelli
2025-05-15 19:03 ` Andrew Lunn
2025-05-16 10:43   ` Stefano Radaelli
2025-05-15 19:15 ` Heiner Kallweit
2025-05-16 10:46   ` Stefano Radaelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4249b016-34c3-4afc-831a-96ba61c3ffce@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lxu@maxlinear.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stefano.radaelli21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®