From: Hou Tao <houtao1@huawei.com>
To: <yizhou.tang@shopee.com>, <jack@suse.cz>, <bvanassche@acm.org>,
<kch@nvidia.com>
Cc: <axboe@kernel.dk>, <tj@kernel.org>, <corbet@lwn.net>,
<linux-block@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yingfu.zhou@shopee.com>,
<chunguang.xu@shopee.com>
Subject: Re: [PATCH] doc: blk-ioprio: Standardize a few names
Date: Wed, 11 Oct 2023 11:34:25 +0800 [thread overview]
Message-ID: <42882d2b-e076-74df-e0bc-2b6c79986d3a@huawei.com> (raw)
In-Reply-To: <20231009100349.52884-1-yizhou.tang@shopee.com>
On 10/9/2023 6:03 PM, yizhou.tang@shopee.com wrote:
> From: Tang Yizhou <yizhou.tang@shopee.com>
>
> Our system administrator have noted that the names 'rt-to-be' and
> 'all-to-idle' in the I/O priority policies table appeared without
> explanations, leading to confusion. Let's standardize these names in
> line with the naming in the 'attribute' section.
>
> Additionally,
> 1. Correct the interface name to 'io.prio.class'.
> 2. Add a table entry of 'promote-to-rt' for consistency.
> 3. Fix a typo of 'priority'.
>
> Suggested-by: Yingfu Zhou <yingfu.zhou@shopee.com>
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: Hou Tao <houtao1@huawei.com>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 4ef890191196..10461c73c9a3 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -2023,7 +2023,7 @@ IO Priority
> ~~~~~~~~~~~
>
> A single attribute controls the behavior of the I/O priority cgroup policy,
> -namely the blkio.prio.class attribute. The following values are accepted for
> +namely the io.prio.class attribute. The following values are accepted for
> that attribute:
>
> no-change
> @@ -2052,9 +2052,11 @@ The following numerical values are associated with the I/O priority policies:
> +----------------+---+
> | no-change | 0 |
> +----------------+---+
> -| rt-to-be | 2 |
> +| promote-to-rt | 1 |
> +----------------+---+
> -| all-to-idle | 3 |
> +| restrict-to-be | 2 |
> ++----------------+---+
> +| idle | 3 |
> +----------------+---+
>
> The numerical value that corresponds to each I/O priority class is as follows:
> @@ -2074,7 +2076,7 @@ The algorithm to set the I/O priority class for a request is as follows:
> - If I/O priority class policy is promote-to-rt, change the request I/O
> priority class to IOPRIO_CLASS_RT and change the request I/O priority
> level to 4.
> -- If I/O priorityt class is not promote-to-rt, translate the I/O priority
> +- If I/O priority class policy is not promote-to-rt, translate the I/O priority
> class policy into a number, then change the request I/O priority class
> into the maximum of the I/O priority class policy number and the numerical
> I/O priority class.
prev parent reply other threads:[~2023-10-11 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 10:03 yizhou.tang
2023-10-11 0:05 ` Bart Van Assche
2023-10-12 2:26 ` Tang Yizhou
2023-10-11 3:34 ` Hou Tao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42882d2b-e076-74df-e0bc-2b6c79986d3a@huawei.com \
--to=houtao1@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chunguang.xu@shopee.com \
--cc=corbet@lwn.net \
--cc=jack@suse.cz \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yingfu.zhou@shopee.com \
--cc=yizhou.tang@shopee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®