Tuner module is too verbose

Tuner module is too verbose

[Damien "tuX" THEBAULT]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

I upgraded from my previous kernel (2.6.10-mm1) to 2.6.12-mm1 today.

I have a problem with the "tuner" module : it is printing too many
messages into the syslog :

"tuner 2-0060: Cmd VIDIOCSCHAN accepted to TV"
or
"tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio"

(about 26 messages per second, but only when watching TV)

I looked into the module's source code and I was able to disable those
messages with a little modification (patch included).
(maybe the same modification is needed when CONFIG_TUNER_MULTI_I2C is
defined)

I don't know if this is the good way to do this, but I didn't find any
other way to solve my problem...

PS : I'm not subscribed to the list so please CC me.

--- ./drivers/media/video/tuner-core.old.c	2005-06-20 18:53:12.864742688
+0200
+++ ./drivers/media/video/tuner-core.c	2005-06-20 19:24:42.382492328
+0200
@@ -201,7 +201,7 @@
 
 #ifdef CONFIG_TUNER_MULTI_I2C
 #define CHECK_ADDR(tp,cmd,tun)	if (client->addr!=tp) { \
-			  return 0; } else \
+			  return 0; } else if (tuner_debug!=0) \
 			  tuner_info ("Cmd %s accepted to "tun"\n",cmd);
 #define CHECK_MODE(cmd)	if (t->mode == V4L2_TUNER_RADIO) { \
 		 	CHECK_ADDR(radio_tuner,cmd,"radio") } else \

-- 
Damien Thebault
public keys on http://pgp.mit.edu

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Tuner module is too verbose

[Mauro Carvalho Chehab]

Damien,

Damien "tuX" THEBAULT wrote:

>I upgraded from my previous kernel (2.6.10-mm1) to 2.6.12-mm1 today.
>
>I have a problem with the "tuner" module : it is printing too many
>messages into the syslog :
>
>"tuner 2-0060: Cmd VIDIOCSCHAN accepted to TV"
>or
>"tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio"
>
>(about -			  return 0; } else \
>+	26 messages per second, but only when watching TV)
>  
>
    This thing is really strange... 26 msg/sec means a tuner change for
every two video frames! More strange is that tuner is switching from
radio mode to video mode. It is also generating 26 I2C calls to tuner by
second. Maybe you are experiencing some performance troubles with this
application bad behavior.

    Maybe there's a radio application that is competing with your TV app.

>I looked into the module's source code and I was able to disable those
>messages with a little modification (patch included).
>(maybe the same modification is needed when CONFIG_TUNER_MULTI_I2C is
>defined)
>
>I don't know if this is the good way to do this, but I didn't find any
>other way to solve my problem...
>
>PS : I'm not subscribed to the list so please CC me.
>
>--- ./drivers/media/video/tuner-core.old.c	2005-06-20 18:53:12.864742688
>+0200
>+++ ./drivers/media/video/tuner-core.c	2005-06-20 19:24:42.382492328
>+0200
>@@ -201,7 +201,7 @@
> 
> #ifdef CONFIG_TUNER_MULTI_I2C
> #define CHECK_ADDR(tp,cmd,tun)	if (client->addr!=tp) { \
>-			  return 0; } else \
>+			  return 0; } else if (tuner_debug!=0) \
> 			  tuner_info ("Cmd %s accepted to "tun"\n",cmd);
> #define CHECK_MODE(cmd)	if (t->mode == V4L2_TUNER_RADIO) { \
> 		 	CHECK_ADDR(radio_tuner,cmd,"radio") } else \
>
>  
>
    Your patch will help aliviating the verbose problem, but maybe you
should check if every radio apps are turned off before calling video
app, since they share the same resources.

Mauro Chehab.

Re: Tuner module is too verbose

[Damien "tuX" THEBAULT]

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

Le mardi 21 juin 2005 à 03:11 -0300, Mauro Carvalho Chehab a écrit :
> 
>     Maybe there's a radio application that is competing with your TV app.

>     Your patch will help aliviating the verbose problem, but maybe you
> should check if every radio apps are turned off before calling video
> app, since they share the same resources.
> 
> Mauro Chehab.

I don't use any radio app.
Sometimes nxtvepg, but that was not the case.
I tried with only one program (xawtv alone, checked with lsof), the
result is the better than with my usual tv app (tvtime) : the messages
only occurs when starting and selecting channels.

For example :

<xawtv start>
[ 3989.965116] tuner 2-0060: Cmd VIDIOCSCHAN accepted to TV
[ 3989.969098] tuner 2-0060: Cmd VIDIOCSCHAN accepted to TV
[ 3989.971804] tuner 2-0060: Cmd VIDIOCSCHAN accepted to TV
[ 3989.974269] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3989.974347] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3989.974420] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3989.974494] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3989.974565] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3990.098003] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3990.099445] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3990.099763] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3990.139961] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3990.140481] tuner 2-0060: Cmd VIDIOCSFREQ accepted to TV
[ 3990.166434] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
<channel change>
[ 3995.931665] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 3995.932022] tuner 2-0060: Cmd VIDIOCSFREQ accepted to TV
[ 3995.960413] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
<xawtv stop>
[ 4000.957714] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio
[ 4002.838733] tuner 2-0060: Cmd VIDIOCGAUDIO accepted to radio

-- 
Damien Thebault
public keys on http://pgp.mit.edu

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]