From: Dan Carpenter <error27@gmail.com>
To: Mingxuan Xiang <mx_xiang@hust.edu.cn>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
hust-os-kernel-patches@googlegroups.com,
Dongliang Mu <dzm91@hust.edu.cn>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in dwc3_host_get_irq()
Date: Thu, 23 Mar 2023 14:12:49 +0300 [thread overview]
Message-ID: <42a2ef2e-b522-40c9-ada2-0e804f7df5d5@kili.mountain> (raw)
In-Reply-To: <e2067012-af9a-4cc7-ba12-3c055d54d915@kili.mountain>
On Thu, Mar 23, 2023 at 02:00:35PM +0300, Dan Carpenter wrote:
> irq = platform_get_irq(dwc3_pdev, 0);
> if (irq > 0) {
> dwc3_host_fill_xhci_irq_res(dwc, irq, NULL);
> - goto out;
> + return irq;
> }
>
> - if (!irq)
> - irq = -EINVAL;
> -
> -out:
> - return irq;
> + return -ENODEV;
Oh wait. We actually need to propagate the error code here because of
-EPROBE_DEFER so my patch introduces a bug.
regards,
dan carpenter
next prev parent reply other threads:[~2023-03-23 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 9:53 Mingxuan Xiang
2023-03-23 10:29 ` Sergei Shtylyov
2023-03-23 10:54 ` Oliver Neukum
2023-03-23 11:13 ` Dan Carpenter
2023-03-23 13:48 ` Oliver Neukum
2023-03-23 14:06 ` Dan Carpenter
2023-03-23 15:38 ` Oliver Neukum
2023-03-23 10:52 ` Dan Carpenter
2023-03-23 11:00 ` Dan Carpenter
2023-03-23 11:12 ` Dan Carpenter [this message]
2023-03-23 15:40 ` Greg Kroah-Hartman
2023-03-24 1:46 ` Dongliang Mu
2023-03-24 5:17 ` Dan Carpenter
2023-03-24 5:19 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a2ef2e-b522-40c9-ada2-0e804f7df5d5@kili.mountain \
--to=error27@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=dzm91@hust.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mx_xiang@hust.edu.cn \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®