From: Dan Carpenter <error27@gmail.com>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mingxuan Xiang <mx_xiang@hust.edu.cn>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
hust-os-kernel-patches@googlegroups.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in dwc3_host_get_irq()
Date: Fri, 24 Mar 2023 08:17:19 +0300 [thread overview]
Message-ID: <adcd6c67-cedf-4831-9a9d-53c3ee2ebb88@kili.mountain> (raw)
In-Reply-To: <8271c37c-4995-445c-89b7-90848f7ef3cc@hust.edu.cn>
On Fri, Mar 24, 2023 at 09:46:40AM +0800, Dongliang Mu wrote:
>
> On 2023/3/23 23:40, Greg Kroah-Hartman wrote:
> > On Thu, Mar 23, 2023 at 05:53:10PM +0800, Mingxuan Xiang wrote:
> > > platform_get_irq() no longer returns 0, so there is no
> > > need to check whether the return value is 0.
> > How did you find this issue?
> >
> > How was it tested?
>
> Hi Greg,
>
> We found this issue by Smatch. Our team is trying fix some true bugs found
> by Smatch, with the help of Dan.
LOL. What did I do to get thrown under the bus like this?
>
> Since this is a dead code removal, we only do compilation testing.
>
Just v3 and mention in the commit message that the issue was found by
Smatch and the warning message that Smatch prints. Put under the ---
cut off line that it has only been compile tested.
Also we needed to send a v3 anyway to remove the {} curly braces.
regards,
dan carpenter
next prev parent reply other threads:[~2023-03-24 5:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 9:53 Mingxuan Xiang
2023-03-23 10:29 ` Sergei Shtylyov
2023-03-23 10:54 ` Oliver Neukum
2023-03-23 11:13 ` Dan Carpenter
2023-03-23 13:48 ` Oliver Neukum
2023-03-23 14:06 ` Dan Carpenter
2023-03-23 15:38 ` Oliver Neukum
2023-03-23 10:52 ` Dan Carpenter
2023-03-23 11:00 ` Dan Carpenter
2023-03-23 11:12 ` Dan Carpenter
2023-03-23 15:40 ` Greg Kroah-Hartman
2023-03-24 1:46 ` Dongliang Mu
2023-03-24 5:17 ` Dan Carpenter [this message]
2023-03-24 5:19 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adcd6c67-cedf-4831-9a9d-53c3ee2ebb88@kili.mountain \
--to=error27@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=dzm91@hust.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mx_xiang@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®