Re: [PATCH v2 2/2] dt: Add bindings for IDT VersaClock 5P49V5925

[Marek Vasut <marek.vasut@gmail.com>]

On 07/09/2017 07:40 PM, Vladimir Barinov wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> 
> IDT VersaClock 5 5P49V5925 has 5 clock outputs, 4 fractional dividers.
> Input clock source can be taken only from external reference clock.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

> ---
> Changes in version 2:
> - fixed typo in patch header: VC5 has 5 clock outputs
> - rebased against patch:
>   [V3,7/8] clk: vc5: Add bindings for IDT VersaClock 5P49V6901
> 
>  Documentation/devicetree/bindings/clock/idt,versaclock5.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> index 66ef0a0..05a245c 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> @@ -8,6 +8,7 @@ generators providing from 3 to 12 output clocks.
>  Required properties:
>  - compatible:	shall be one of
>  		"idt,5p49v5923"
> +		"idt,5p49v5925"
>  		"idt,5p49v5933"
>  		"idt,5p49v5935"
>  		"idt,5p49v6901"
> @@ -15,6 +16,7 @@ Required properties:
>  - #clock-cells:	from common clock binding; shall be set to 1.
>  - clocks:	from common clock binding; list of parent clock handles,
>  		- 5p49v5923 and
> +		  5p49v5925 and
>  		  5p49v6901: (required) either or both of XTAL or CLKIN
>  					reference clock.
>  		- 5p49v5933 and
> @@ -23,6 +25,7 @@ Required properties:
>  					clock.
>  - clock-names:	from common clock binding; clock input names, can be
>  		- 5p49v5923 and
> +		  5p49v5925 and
>  		  5p49v6901: (required) either or both of "xin", "clkin".
>  		- 5p49v5933 and
>  		- 5p49v5935: (optional) property not present or "clkin".
> @@ -42,6 +45,7 @@ clock specifier, the following mapping applies:
>  	1 -- OUT1
>  	2 -- OUT4
>  
> +5P49V5925 and
>  5P49V5935:
>  	0 -- OUT0_SEL_I2CB
>  	1 -- OUT1
> 


-- 
Best regards,
Marek Vasut