From: Javier Martinez Canillas <javierm@redhat.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-fbdev@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Maxime Ripard" <maxime@cerno.tech>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line()
Date: Fri, 11 Feb 2022 13:11:25 +0100 [thread overview]
Message-ID: <431f26fb-5943-eb58-9ad5-eda787966ad2@redhat.com> (raw)
In-Reply-To: <87pmnt7gm3.fsf@intel.com>
Hello Jani,
On 2/11/22 13:05, Jani Nikula wrote:
[snip]
>>>> I don't see why a while loop would be an improvement here TBH.
>>>
>>> Less letters to parse when reading the code.
>>
>> It's a simple refactoring of code that has worked well so far. Let's
>> leave it as-is for now.
>
> IMO *always* prefer a for loop over while or do-while.
>
> The for (i = 0; i < N; i++) is such a strong paradigm in C. You
> instantly know how many times you're going to loop, at a glance. Not so
> with with the alternatives, which should be used sparingly.
>
> And yes, the do-while suggested above is buggy, and you actually need to
> stop and think to see why.
>
Absolutely agree.
These format conversion helpers are not trivial to read and understand (at
least for me). In my opinion the code should be written in a way that ease
readability and make as robust and less error prone as possible.
>
> BR,
> Jani.
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-02-11 12:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 9:19 [PATCH v4 0/6] drm: Add driver for Solomon SSD130x OLED displays Javier Martinez Canillas
2022-02-11 9:19 ` [PATCH v4 1/6] drm/format-helper: Add drm_fb_xrgb8888_to_gray8_line() Javier Martinez Canillas
2022-02-11 9:29 ` Thomas Zimmermann
2022-02-11 10:28 ` Andy Shevchenko
2022-02-11 10:40 ` Javier Martinez Canillas
2022-02-11 11:12 ` Andy Shevchenko
2022-02-11 11:54 ` Thomas Zimmermann
2022-02-11 12:05 ` Jani Nikula
2022-02-11 12:11 ` Javier Martinez Canillas [this message]
2022-02-11 12:27 ` Geert Uytterhoeven
2022-02-11 15:41 ` Andy Shevchenko
2022-02-11 16:25 ` Jani Nikula
2022-02-11 17:27 ` Andy Shevchenko
2022-02-14 9:17 ` Pekka Paalanen
2022-02-14 10:26 ` Andy Shevchenko
2022-02-14 9:03 ` Thomas Zimmermann
2022-02-14 10:38 ` Andy Shevchenko
2022-02-14 10:52 ` Simon Ser
2022-02-14 10:57 ` Geert Uytterhoeven
2022-02-14 12:12 ` Thomas Zimmermann
2022-02-14 12:47 ` Ville Syrjälä
2022-02-14 12:54 ` Thomas Zimmermann
2022-02-14 13:07 ` Ville Syrjälä
2022-02-14 13:59 ` Andy Shevchenko
2022-02-11 9:19 ` [PATCH v4 2/6] drm/format-helper: Add drm_fb_xrgb8888_to_mono_reversed() Javier Martinez Canillas
2022-02-11 11:10 ` Andy Shevchenko
2022-02-11 11:50 ` Javier Martinez Canillas
2022-02-11 15:55 ` Andy Shevchenko
2022-02-11 11:59 ` Thomas Zimmermann
2022-02-11 12:46 ` Thomas Zimmermann
2022-02-11 9:19 ` [PATCH v4 3/6] drm: Add driver for Solomon SSD130x OLED displays Javier Martinez Canillas
2022-02-11 11:33 ` Andy Shevchenko
2022-02-11 12:05 ` Javier Martinez Canillas
2022-02-11 12:23 ` Geert Uytterhoeven
2022-02-11 12:27 ` Javier Martinez Canillas
2022-02-11 15:49 ` Andy Shevchenko
2022-02-11 12:44 ` Thomas Zimmermann
2022-02-11 9:19 ` [PATCH v4 4/6] drm/solomon: Add SSD130x OLED displays I2C support Javier Martinez Canillas
2022-02-11 11:16 ` Andy Shevchenko
2022-02-11 9:21 ` [PATCH v4 5/6] MAINTAINERS: Add entry for Solomon SSD130x OLED displays DRM driver Javier Martinez Canillas
2022-02-11 11:34 ` Andy Shevchenko
2022-02-11 9:22 ` [PATCH v4 6/6] dt-bindings: display: ssd1307fb: Add myself as binding co-maintainer Javier Martinez Canillas
2022-02-11 11:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431f26fb-5943-eb58-9ad5-eda787966ad2@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®