From: "Bryan O'Sullivan" <bos@pathscale.com>
To: rdreier@cisco.com
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2 of 23] IB/ipath - lock resource limit counters correctly
Date: Fri, 25 Aug 2006 11:24:27 -0700 [thread overview]
Message-ID: <4326e8fdb03d3ca806c6.1156530267@eng-12.pathscale.com> (raw)
In-Reply-To: <patchbomb.1156530265@eng-12.pathscale.com>
Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>
diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.c b/drivers/infiniband/hw/ipath/ipath_verbs.c
--- a/drivers/infiniband/hw/ipath/ipath_verbs.c Fri Aug 25 11:19:44 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_verbs.c Fri Aug 25 11:19:44 2006 -0700
@@ -776,18 +776,22 @@ static struct ib_pd *ipath_alloc_pd(stru
* we allow allocations of more than we report for this value.
*/
- if (dev->n_pds_allocated == ib_ipath_max_pds) {
- ret = ERR_PTR(-ENOMEM);
- goto bail;
- }
-
pd = kmalloc(sizeof *pd, GFP_KERNEL);
if (!pd) {
ret = ERR_PTR(-ENOMEM);
goto bail;
}
+ spin_lock(&dev->n_pds_lock);
+ if (dev->n_pds_allocated == ib_ipath_max_pds) {
+ spin_unlock(&dev->n_pds_lock);
+ kfree(pd);
+ ret = ERR_PTR(-ENOMEM);
+ goto bail;
+ }
+
dev->n_pds_allocated++;
+ spin_unlock(&dev->n_pds_lock);
/* ib_alloc_pd() will initialize pd->ibpd. */
pd->user = udata != NULL;
@@ -803,7 +807,9 @@ static int ipath_dealloc_pd(struct ib_pd
struct ipath_pd *pd = to_ipd(ibpd);
struct ipath_ibdev *dev = to_idev(ibpd->device);
+ spin_lock(&dev->n_pds_lock);
dev->n_pds_allocated--;
+ spin_unlock(&dev->n_pds_lock);
kfree(pd);
@@ -824,11 +830,6 @@ static struct ib_ah *ipath_create_ah(str
struct ib_ah *ret;
struct ipath_ibdev *dev = to_idev(pd->device);
- if (dev->n_ahs_allocated == ib_ipath_max_ahs) {
- ret = ERR_PTR(-ENOMEM);
- goto bail;
- }
-
/* A multicast address requires a GRH (see ch. 8.4.1). */
if (ah_attr->dlid >= IPATH_MULTICAST_LID_BASE &&
ah_attr->dlid != IPATH_PERMISSIVE_LID &&
@@ -854,7 +855,16 @@ static struct ib_ah *ipath_create_ah(str
goto bail;
}
+ spin_lock(&dev->n_ahs_lock);
+ if (dev->n_ahs_allocated == ib_ipath_max_ahs) {
+ spin_unlock(&dev->n_ahs_lock);
+ kfree(ah);
+ ret = ERR_PTR(-ENOMEM);
+ goto bail;
+ }
+
dev->n_ahs_allocated++;
+ spin_unlock(&dev->n_ahs_lock);
/* ib_create_ah() will initialize ah->ibah. */
ah->attr = *ah_attr;
@@ -876,7 +886,9 @@ static int ipath_destroy_ah(struct ib_ah
struct ipath_ibdev *dev = to_idev(ibah->device);
struct ipath_ah *ah = to_iah(ibah);
+ spin_lock(&dev->n_ahs_lock);
dev->n_ahs_allocated--;
+ spin_unlock(&dev->n_ahs_lock);
kfree(ah);
@@ -963,6 +975,12 @@ static void *ipath_register_ib_device(in
dev = &idev->ibdev;
/* Only need to initialize non-zero fields. */
+ spin_lock_init(&idev->n_pds_lock);
+ spin_lock_init(&idev->n_ahs_lock);
+ spin_lock_init(&idev->n_cqs_lock);
+ spin_lock_init(&idev->n_srqs_lock);
+ spin_lock_init(&idev->n_mcast_grps_lock);
+
spin_lock_init(&idev->qp_table.lock);
spin_lock_init(&idev->lk_table.lock);
idev->sm_lid = __constant_be16_to_cpu(IB_LID_PERMISSIVE);
diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.h b/drivers/infiniband/hw/ipath/ipath_verbs.h
--- a/drivers/infiniband/hw/ipath/ipath_verbs.h Fri Aug 25 11:19:44 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_verbs.h Fri Aug 25 11:19:44 2006 -0700
@@ -434,11 +434,18 @@ struct ipath_ibdev {
__be64 sys_image_guid; /* in network order */
__be64 gid_prefix; /* in network order */
__be64 mkey;
+
u32 n_pds_allocated; /* number of PDs allocated for device */
+ spinlock_t n_pds_lock;
u32 n_ahs_allocated; /* number of AHs allocated for device */
+ spinlock_t n_ahs_lock;
u32 n_cqs_allocated; /* number of CQs allocated for device */
+ spinlock_t n_cqs_lock;
u32 n_srqs_allocated; /* number of SRQs allocated for device */
+ spinlock_t n_srqs_lock;
u32 n_mcast_grps_allocated; /* number of mcast groups allocated */
+ spinlock_t n_mcast_grps_lock;
+
u64 ipath_sword; /* total dwords sent (sample result) */
u64 ipath_rword; /* total dwords received (sample result) */
u64 ipath_spkts; /* total packets sent (sample result) */
diff --git a/drivers/infiniband/hw/ipath/ipath_verbs_mcast.c b/drivers/infiniband/hw/ipath/ipath_verbs_mcast.c
--- a/drivers/infiniband/hw/ipath/ipath_verbs_mcast.c Fri Aug 25 11:19:44 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_verbs_mcast.c Fri Aug 25 11:19:44 2006 -0700
@@ -207,12 +207,15 @@ static int ipath_mcast_add(struct ipath_
goto bail;
}
+ spin_lock(&dev->n_mcast_grps_lock);
if (dev->n_mcast_grps_allocated == ib_ipath_max_mcast_grps) {
+ spin_unlock(&dev->n_mcast_grps_lock);
ret = ENOMEM;
goto bail;
}
dev->n_mcast_grps_allocated++;
+ spin_unlock(&dev->n_mcast_grps_lock);
list_add_tail_rcu(&mqp->list, &mcast->qp_list);
@@ -343,7 +346,9 @@ int ipath_multicast_detach(struct ib_qp
atomic_dec(&mcast->refcount);
wait_event(mcast->wait, !atomic_read(&mcast->refcount));
ipath_mcast_free(mcast);
+ spin_lock(&dev->n_mcast_grps_lock);
dev->n_mcast_grps_allocated--;
+ spin_unlock(&dev->n_mcast_grps_lock);
}
ret = 0;
next prev parent reply other threads:[~2006-08-25 18:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 18:24 [PATCH 0 of 23] IB/ipath - updates for 2.6.19 Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 1 of 23] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems Bryan O'Sullivan
2006-08-25 19:45 ` Roland Dreier
2006-08-25 20:19 ` Bryan O'Sullivan
2006-08-29 23:04 ` Brendan Cully
2006-08-25 20:01 ` Roland Dreier
2006-08-25 18:24 ` Bryan O'Sullivan [this message]
2006-08-25 18:24 ` [PATCH 3 of 23] IB/ipath - fix for crash on module unload, if cfgports < portcnt Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 4 of 23] IB/ipath - fix handling of kpiobufs Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 5 of 23] IB/ipath - drop requirement that PIO buffers be mmaped write-only Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 6 of 23] IB/ipath - merge ipath_core and ib_ipath drivers Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 7 of 23] IB/ipath - simplify layering code Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 8 of 23] IB/ipath - simplify debugging code after ipath_core and ib_ipath merger Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 9 of 23] IB/ipath - remove stale references to userspace SMA Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 10 of 23] IB/ipath - trivial cleanups Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 11 of 23] IB/ipath - add new minor device to allow sending of diag packets Bryan O'Sullivan
2006-08-25 19:50 ` Roland Dreier
2006-08-25 20:20 ` Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 12 of 23] IB/ipath - do not allow use of CQ entries with invalid counts Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 13 of 23] IB/ipath - account for attached QPs correctly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 14 of 23] IB/ipath - support new QLogic product naming scheme Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 15 of 23] IB/ipath - add serial number to hardware freeze error message Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 16 of 23] IB/ipath - be more strict about testing the modify QP verb Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 17 of 23] IB/ipath - validate path_mig_state properly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 18 of 23] IB/ipath - put a limit on the number of QPs that can be created Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 19 of 23] IB/ipath - handle sq_sig_all field correctly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 20 of 23] IB/ipath - allow SMA to be disabled Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 21 of 23] IB/ipath - fix return value from ipath_poll Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute Bryan O'Sullivan
2006-08-25 19:35 ` Roland Dreier
2006-08-25 20:40 ` [openib-general] " Robert Walsh
2006-08-26 19:31 ` Michael S. Tsirkin
2006-08-27 22:25 ` Roland Dreier
2006-08-28 1:41 ` Robert Walsh
2006-08-25 18:24 ` [PATCH 23 of 23] IB/ipath - control receive polarity inversion Bryan O'Sullivan
2006-08-25 20:01 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4326e8fdb03d3ca806c6.1156530267@eng-12.pathscale.com \
--to=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®