From: "Bryan O'Sullivan" <bos@pathscale.com>
To: rdreier@cisco.com
Cc: openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: [PATCH 23 of 23] IB/ipath - control receive polarity inversion
Date: Fri, 25 Aug 2006 11:24:48 -0700 [thread overview]
Message-ID: <7a03a7b18dcfe1afeeb1.1156530288@eng-12.pathscale.com> (raw)
In-Reply-To: <patchbomb.1156530265@eng-12.pathscale.com>
Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>
diff --git a/drivers/infiniband/hw/ipath/ipath_driver.c b/drivers/infiniband/hw/ipath/ipath_driver.c
--- a/drivers/infiniband/hw/ipath/ipath_driver.c Fri Aug 25 11:19:46 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_driver.c Fri Aug 25 11:19:46 2006 -0700
@@ -2156,5 +2156,22 @@ bail:
return ret;
}
+int ipath_set_rx_pol_inv(struct ipath_devdata *dd, u8 new_pol_inv)
+{
+ u64 val;
+ if ( new_pol_inv > INFINIPATH_XGXS_RX_POL_MASK ) {
+ return -1;
+ }
+ if ( dd->ipath_rx_pol_inv != new_pol_inv ) {
+ dd->ipath_rx_pol_inv = new_pol_inv;
+ val = ipath_read_kreg64(dd, dd->ipath_kregs->kr_xgxsconfig);
+ val &= ~(INFINIPATH_XGXS_RX_POL_MASK <<
+ INFINIPATH_XGXS_RX_POL_SHIFT);
+ val |= ((u64)dd->ipath_rx_pol_inv) <<
+ INFINIPATH_XGXS_RX_POL_SHIFT;
+ ipath_write_kreg(dd, dd->ipath_kregs->kr_xgxsconfig, val);
+ }
+ return 0;
+}
module_init(infinipath_init);
module_exit(infinipath_cleanup);
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6110.c b/drivers/infiniband/hw/ipath/ipath_iba6110.c
--- a/drivers/infiniband/hw/ipath/ipath_iba6110.c Fri Aug 25 11:19:46 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_iba6110.c Fri Aug 25 11:19:46 2006 -0700
@@ -1290,6 +1290,15 @@ static int ipath_ht_bringup_serdes(struc
val &= ~INFINIPATH_XGXS_RESET;
change = 1;
}
+ if (((val >> INFINIPATH_XGXS_RX_POL_SHIFT) &
+ INFINIPATH_XGXS_RX_POL_MASK) != dd->ipath_rx_pol_inv ) {
+ /* need to compensate for Tx inversion in partner */
+ val &= ~(INFINIPATH_XGXS_RX_POL_MASK <<
+ INFINIPATH_XGXS_RX_POL_SHIFT);
+ val |= dd->ipath_rx_pol_inv <<
+ INFINIPATH_XGXS_RX_POL_SHIFT;
+ change = 1;
+ }
if (change)
ipath_write_kreg(dd, dd->ipath_kregs->kr_xgxsconfig, val);
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6120.c b/drivers/infiniband/hw/ipath/ipath_iba6120.c
--- a/drivers/infiniband/hw/ipath/ipath_iba6120.c Fri Aug 25 11:19:46 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_iba6120.c Fri Aug 25 11:19:46 2006 -0700
@@ -654,6 +654,15 @@ static int ipath_pe_bringup_serdes(struc
val &= ~INFINIPATH_XGXS_RESET;
change = 1;
}
+ if (((val >> INFINIPATH_XGXS_RX_POL_SHIFT) &
+ INFINIPATH_XGXS_RX_POL_MASK) != dd->ipath_rx_pol_inv ) {
+ /* need to compensate for Tx inversion in partner */
+ val &= ~(INFINIPATH_XGXS_RX_POL_MASK <<
+ INFINIPATH_XGXS_RX_POL_SHIFT);
+ val |= dd->ipath_rx_pol_inv <<
+ INFINIPATH_XGXS_RX_POL_SHIFT;
+ change = 1;
+ }
if (change)
ipath_write_kreg(dd, dd->ipath_kregs->kr_xgxsconfig, val);
diff --git a/drivers/infiniband/hw/ipath/ipath_kernel.h b/drivers/infiniband/hw/ipath/ipath_kernel.h
--- a/drivers/infiniband/hw/ipath/ipath_kernel.h Fri Aug 25 11:19:46 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_kernel.h Fri Aug 25 11:19:46 2006 -0700
@@ -503,6 +503,8 @@ struct ipath_devdata {
u8 ipath_pci_cacheline;
/* LID mask control */
u8 ipath_lmc;
+ /* Rx Polarity inversion (compensate for ~tx on partner) */
+ u8 ipath_rx_pol_inv;
/* local link integrity counter */
u32 ipath_lli_counter;
@@ -570,6 +572,7 @@ int ipath_set_linkstate(struct ipath_dev
int ipath_set_linkstate(struct ipath_devdata *, u8);
int ipath_set_mtu(struct ipath_devdata *, u16);
int ipath_set_lid(struct ipath_devdata *, u32, u8);
+int ipath_set_rx_pol_inv(struct ipath_devdata *dd, u8 new_pol_inv);
/* for use in system calls, where we want to know device type, etc. */
#define port_fp(fp) ((struct ipath_portdata *) (fp)->private_data)
diff --git a/drivers/infiniband/hw/ipath/ipath_registers.h b/drivers/infiniband/hw/ipath/ipath_registers.h
--- a/drivers/infiniband/hw/ipath/ipath_registers.h Fri Aug 25 11:19:46 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_registers.h Fri Aug 25 11:19:46 2006 -0700
@@ -282,6 +282,8 @@
#define INFINIPATH_XGXS_RESET 0x7ULL
#define INFINIPATH_XGXS_MDIOADDR_MASK 0xfULL
#define INFINIPATH_XGXS_MDIOADDR_SHIFT 4
+#define INFINIPATH_XGXS_RX_POL_SHIFT 19
+#define INFINIPATH_XGXS_RX_POL_MASK 0xfULL
#define INFINIPATH_RT_ADDR_MASK 0xFFFFFFFFFFULL /* 40 bits valid */
diff --git a/drivers/infiniband/hw/ipath/ipath_sysfs.c b/drivers/infiniband/hw/ipath/ipath_sysfs.c
--- a/drivers/infiniband/hw/ipath/ipath_sysfs.c Fri Aug 25 11:19:46 2006 -0700
+++ b/drivers/infiniband/hw/ipath/ipath_sysfs.c Fri Aug 25 11:19:46 2006 -0700
@@ -561,6 +561,33 @@ bail:
return ret;
}
+static ssize_t store_rx_pol_inv(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf,
+ size_t count)
+{
+ struct ipath_devdata *dd = dev_get_drvdata(dev);
+ int ret, r;
+ u16 val;
+
+ ret = ipath_parse_ushort(buf, &val);
+ if (ret < 0)
+ goto invalid;
+
+ r = ipath_set_rx_pol_inv(dd, val);
+ if (r < 0) {
+ ret = r;
+ goto bail;
+ }
+
+ goto bail;
+invalid:
+ ipath_dev_err(dd, "attempt to set invalid Rx Polarity invert\n");
+bail:
+ return ret;
+}
+
+
static DRIVER_ATTR(num_units, S_IRUGO, show_num_units, NULL);
static DRIVER_ATTR(version, S_IRUGO, show_version, NULL);
@@ -587,6 +614,7 @@ static DEVICE_ATTR(status_str, S_IRUGO,
static DEVICE_ATTR(status_str, S_IRUGO, show_status_str, NULL);
static DEVICE_ATTR(boardversion, S_IRUGO, show_boardversion, NULL);
static DEVICE_ATTR(unit, S_IRUGO, show_unit, NULL);
+static DEVICE_ATTR(rx_pol_inv, S_IWUSR, NULL, store_rx_pol_inv);
static struct attribute *dev_attributes[] = {
&dev_attr_guid.attr,
@@ -601,6 +629,7 @@ static struct attribute *dev_attributes[
&dev_attr_boardversion.attr,
&dev_attr_unit.attr,
&dev_attr_enabled.attr,
+ &dev_attr_rx_pol_inv.attr,
NULL
};
next prev parent reply other threads:[~2006-08-25 18:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 18:24 [PATCH 0 of 23] IB/ipath - updates for 2.6.19 Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 1 of 23] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems Bryan O'Sullivan
2006-08-25 19:45 ` Roland Dreier
2006-08-25 20:19 ` Bryan O'Sullivan
2006-08-29 23:04 ` Brendan Cully
2006-08-25 20:01 ` Roland Dreier
2006-08-25 18:24 ` [PATCH 2 of 23] IB/ipath - lock resource limit counters correctly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 3 of 23] IB/ipath - fix for crash on module unload, if cfgports < portcnt Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 4 of 23] IB/ipath - fix handling of kpiobufs Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 5 of 23] IB/ipath - drop requirement that PIO buffers be mmaped write-only Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 6 of 23] IB/ipath - merge ipath_core and ib_ipath drivers Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 7 of 23] IB/ipath - simplify layering code Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 8 of 23] IB/ipath - simplify debugging code after ipath_core and ib_ipath merger Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 9 of 23] IB/ipath - remove stale references to userspace SMA Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 10 of 23] IB/ipath - trivial cleanups Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 11 of 23] IB/ipath - add new minor device to allow sending of diag packets Bryan O'Sullivan
2006-08-25 19:50 ` Roland Dreier
2006-08-25 20:20 ` Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 12 of 23] IB/ipath - do not allow use of CQ entries with invalid counts Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 13 of 23] IB/ipath - account for attached QPs correctly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 14 of 23] IB/ipath - support new QLogic product naming scheme Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 15 of 23] IB/ipath - add serial number to hardware freeze error message Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 16 of 23] IB/ipath - be more strict about testing the modify QP verb Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 17 of 23] IB/ipath - validate path_mig_state properly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 18 of 23] IB/ipath - put a limit on the number of QPs that can be created Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 19 of 23] IB/ipath - handle sq_sig_all field correctly Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 20 of 23] IB/ipath - allow SMA to be disabled Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 21 of 23] IB/ipath - fix return value from ipath_poll Bryan O'Sullivan
2006-08-25 18:24 ` [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute Bryan O'Sullivan
2006-08-25 19:35 ` Roland Dreier
2006-08-25 20:40 ` [openib-general] " Robert Walsh
2006-08-26 19:31 ` Michael S. Tsirkin
2006-08-27 22:25 ` Roland Dreier
2006-08-28 1:41 ` Robert Walsh
2006-08-25 18:24 ` Bryan O'Sullivan [this message]
2006-08-25 20:01 ` [PATCH 23 of 23] IB/ipath - control receive polarity inversion Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a03a7b18dcfe1afeeb1.1156530288@eng-12.pathscale.com \
--to=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®