* [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue @ 2017-06-11 18:44 Jaya Durga 2017-06-12 12:12 ` Dan Carpenter 2017-06-12 20:57 ` [10/10] " Guenter Roeck 0 siblings, 2 replies; 5+ messages in thread From: Jaya Durga @ 2017-06-11 18:44 UTC (permalink / raw) To: gregkh Cc: Larry.Finger, florian.c.schilhabel, driverdev-devel, devel, linux-kernel, Jaya Durga Fixed WARNING: line over 80 characters Signed-off-by: Jaya Durga <jayad@cdac.in> --- drivers/staging/rtl8712/ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index 6e673c1..97ef063 100644 --- a/drivers/staging/rtl8712/ieee80211.c +++ b/drivers/staging/rtl8712/ieee80211.c @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv) sz += 8; ie += sz; /*beacon interval : 2bytes*/ - *(__le16 *)ie = cpu_to_le16( - (u16)pdev_network->configuration.beacon_period); + struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration; + *(__le16 *)ie = cpu_to_le16(cfg->beacon_period); sz += 2; ie += 2; /*capability info*/ -- 1.9.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue 2017-06-11 18:44 [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue Jaya Durga @ 2017-06-12 12:12 ` Dan Carpenter [not found] ` <1515429128.1447.1497331078332.JavaMail.open-xchange@webmail.cdac.in> 2017-06-12 20:57 ` [10/10] " Guenter Roeck 1 sibling, 1 reply; 5+ messages in thread From: Dan Carpenter @ 2017-06-12 12:12 UTC (permalink / raw) To: Jaya Durga Cc: gregkh, devel, florian.c.schilhabel, driverdev-devel, linux-kernel, Larry.Finger The patch numbering doesn't make sense. regards, dan carpenter ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1515429128.1447.1497331078332.JavaMail.open-xchange@webmail.cdac.in>]
* Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue [not found] ` <1515429128.1447.1497331078332.JavaMail.open-xchange@webmail.cdac.in> @ 2017-06-13 5:55 ` Greg KH 2017-06-13 6:52 ` R Jayadurga 0 siblings, 1 reply; 5+ messages in thread From: Greg KH @ 2017-06-13 5:55 UTC (permalink / raw) To: R Jayadurga Cc: Dan Carpenter, florian.c.schilhabel, Larry.Finger, linux-kernel, driverdev-devel, devel On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote: > This e-mail is for the sole use of the intended recipient(s) and may > contain confidential and privileged information. If you are not the > intended recipient, please contact the sender by reply e-mail and destroy > all copies and the original message. Any unauthorized review, use, > disclosure, dissemination, forwarding, printing or copying of this email > is strictly prohibited and appropriate legal action will be taken. > ------------------------------------------------------------------------------------------------------------------------------- As per your footer, I am deleting your email. Please note that I'm really not supposed to be responding to this at all, as this type of text is not allowed at all on kernel development mialing lists... ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue 2017-06-13 5:55 ` Greg KH @ 2017-06-13 6:52 ` R Jayadurga 0 siblings, 0 replies; 5+ messages in thread From: R Jayadurga @ 2017-06-13 6:52 UTC (permalink / raw) To: Greg KH Cc: florian.c.schilhabel, Dan Carpenter, Larry.Finger, linux-kernel, driverdev-devel, devel sorry for the inconvenience caused i have corrected it. Regards, Jaya Durga R On June 13, 2017 at 11:25 AM Greg KH <gregkh@linuxfoundation.org> wrote: > On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote: > > This e-mail is for the sole use of the intended recipient(s) and may > > contain confidential and privileged information. If you are not the > > intended recipient, please contact the sender by reply e-mail and destroy > > all copies and the original message. Any unauthorized review, use, > > disclosure, dissemination, forwarding, printing or copying of this email > > is strictly prohibited and appropriate legal action will be taken. > > ------------------------------------------------------------------------------------------------------------------------------- > > As per your footer, I am deleting your email. > > Please note that I'm really not supposed to be responding to this at > all, as this type of text is not allowed at all on kernel development > mialing lists... ------------------------------------------------------------------------------------------------------------------------------- [ C-DAC is on Social-Media too. Kindly follow us at: Facebook: https://www.facebook.com/CDACINDIA & Twitter: @cdacindia ] This e-mail is for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies and the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email is strictly prohibited and appropriate legal action will be taken. ------------------------------------------------------------------------------------------------------------------------------- ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue 2017-06-11 18:44 [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue Jaya Durga 2017-06-12 12:12 ` Dan Carpenter @ 2017-06-12 20:57 ` Guenter Roeck 1 sibling, 0 replies; 5+ messages in thread From: Guenter Roeck @ 2017-06-12 20:57 UTC (permalink / raw) To: Jaya Durga Cc: gregkh, Larry.Finger, florian.c.schilhabel, driverdev-devel, devel, linux-kernel On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote: > Fixed WARNING: line over 80 characters > > Signed-off-by: Jaya Durga <jayad@cdac.in> > --- > drivers/staging/rtl8712/ieee80211.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 1.9.1 > > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c > index 6e673c1..97ef063 100644 > --- a/drivers/staging/rtl8712/ieee80211.c > +++ b/drivers/staging/rtl8712/ieee80211.c > @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv) > sz += 8; > ie += sz; > /*beacon interval : 2bytes*/ > - *(__le16 *)ie = cpu_to_le16( > - (u16)pdev_network->configuration.beacon_period); > + struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration; > + *(__le16 *)ie = cpu_to_le16(cfg->beacon_period); Do you really think that the resulting drivers/staging/rtl8712/ieee80211.c:177:2: warning: ISO C90 forbids mixed declarations and code is better ? Guenter > sz += 2; > ie += 2; > /*capability info*/ ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-13 6:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-11 18:44 [PATCH 10/10] Staging: rtl8712: ieee80211: fixed coding style issue Jaya Durga
2017-06-12 12:12 ` Dan Carpenter
[not found] ` <1515429128.1447.1497331078332.JavaMail.open-xchange@webmail.cdac.in>
2017-06-13 5:55 ` Greg KH
2017-06-13 6:52 ` R Jayadurga
2017-06-12 20:57 ` [10/10] " Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome