mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Quan Nguyen <quan@os.amperecomputing.com>
To: Potin Lai <potin.lai.pt@gmail.com>,
	Corey Minyard <minyard@acm.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Patrick Williams <patrick@stwcx.xyz>
Cc: openipmi-developer@lists.sourceforge.net,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Cosmo Chou <cosmo.chou@quantatw.com>,
	Potin Lai <potin.lai@quantatw.com>,
	Cosmo Chou <chou.cosmo@gmail.com>
Subject: Re: [PATCH v2 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism
Date: Thu, 24 Oct 2024 11:29:42 +0700	[thread overview]
Message-ID: <434333fb-5703-449e-83f2-46e85f34fd23@os.amperecomputing.com> (raw)
In-Reply-To: <20241022-ssif-alert-gpios-v2-2-c7dd6dd17a7e@gmail.com>



On 22/10/2024 08:20, Potin Lai wrote:
> From: Cosmo Chou <chou.cosmo@gmail.com>
> 
> Implement GPIO-based alert mechanism in the SSIF BMC driver to notify
> the host when a response is ready.
> 
> This improves host-BMC communication efficiency by providing immediate
> notification, potentially reducing host polling overhead.
> 
> Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
> ---
>   drivers/char/ipmi/ssif_bmc.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 

Thanks for adding feature to this driver, the code looks good to me.

Reviewed-by: Quan Nguyen <quan@os.amperecomputing.com>

I'm just have a bit of curious on how the ipmi_ssif in host side to work 
with this mechanism? Will there be patches for ipmi_ssif to use this 
feature followed?

Thanks and Best regards,
- Quan

  reply	other threads:[~2024-10-24  4:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  1:20 [PATCH v2 0/2] ipmi: ssif_bmc: Add " Potin Lai
2024-10-22  1:20 ` [PATCH v2 1/2] bindings: ipmi: Add alert GPIO enhancement for SSIF BMC driver Potin Lai
2024-10-22  5:59   ` Krzysztof Kozlowski
2024-10-22  1:20 ` [PATCH v2 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism Potin Lai
2024-10-24  4:29   ` Quan Nguyen [this message]
2024-11-19  1:47     ` Potin Lai
2024-11-19 11:30     ` Corey Minyard
2024-11-20  1:58       ` Quan Nguyen
2024-11-20  2:31         ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434333fb-5703-449e-83f2-46e85f34fd23@os.amperecomputing.com \
    --to=quan@os.amperecomputing.com \
    --cc=chou.cosmo@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=cosmo.chou@quantatw.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=patrick@stwcx.xyz \
    --cc=potin.lai.pt@gmail.com \
    --cc=potin.lai@quantatw.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®