Re: [PATCH v2 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism

[Quan Nguyen <quan@os.amperecomputing.com>]

On 19/11/2024 18:30, Corey Minyard wrote:
> On Wed, Oct 23, 2024 at 11:30 PM Quan Nguyen
> <quan@os.amperecomputing.com> wrote:
>>
>>
>>
>> On 22/10/2024 08:20, Potin Lai wrote:
>>> From: Cosmo Chou <chou.cosmo@gmail.com>
>>>
>>> Implement GPIO-based alert mechanism in the SSIF BMC driver to notify
>>> the host when a response is ready.
>>>
>>> This improves host-BMC communication efficiency by providing immediate
>>> notification, potentially reducing host polling overhead.
>>>
>>> Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
>>> ---
>>>    drivers/char/ipmi/ssif_bmc.c | 15 +++++++++++++++
>>>    1 file changed, 15 insertions(+)
>>>
>>
>> Thanks for adding feature to this driver, the code looks good to me.
>>
>> Reviewed-by: Quan Nguyen <quan@os.amperecomputing.com>
>>
>> I'm just have a bit of curious on how the ipmi_ssif in host side to work
>> with this mechanism? Will there be patches for ipmi_ssif to use this
>> feature followed?
> 
> I just saw this.  What makes you think alerts are not supported in ipmi_ssif?
> 

Yes, Corey, I see alerts are supported in ipmi_ssif.

My apology about the unclear question, I was just curious about whether 
this gpio-based alerts mechanism is confirmed through test with current 
ipmi_ssif without any extra patches.

Thanks,
- Quan