Re: [PATCH] clk: qcom: gcc-ipq5424: drop the CLK_IGNORE_UNUSED flag

[Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>]

On 5/25/2026 8:55 PM, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 08:35:16PM +0530, Kathiravan Thirumoorthy wrote:
>> On 5/25/2026 3:39 PM, Dmitry Baryshkov wrote:
>>> On Mon, May 25, 2026 at 03:07:17PM +0530, Kathiravan Thirumoorthy wrote:
>>>> Now that Linux has the consumer for the GPLL4, drop the
>>> what is the consumer? When was it added?
>> PCIe and USB are the major consumers, which got added with the below commits
>> and landed in v6.16 and v6.14 respectively.
>>
>> ab7f31a3830d ("arm64: dts: qcom: ipq5424: Add PCIe PHYs and controller
>> nodes")
>>
>> 113d52bdc820 ("arm64: dts: qcom: ipq5424: Add USB controller and phy nodes")
>>
>> While I was revisiting the code found that this flag is not removed. Hence I
>> sent this.
>>
>> Shall I reword the commit message as below for the next spin?
>>
>> --
>>
>> Since PCIe and USB are enabled and consume GPLL4, there is no need to
>> keep the CLK_IGNORE_UNUSED flag. Drop it.
> Yes, it would be perfect. BTW: what happens if both are disabled (or not
> probed at the boot time)?

Until all the drivers probed, icc_sync_state() will not disable the ICC 
clocks which will in turn keep GPLL4 in ON state. If we disable the 
nodes, then system will go for the reboot without much information.

>
>