From: Vignesh R <vigneshr@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq()
Date: Thu, 9 Mar 2017 20:07:24 +0530 [thread overview]
Message-ID: <435d73f7-d057-631b-8d00-8639d764414f@ti.com> (raw)
In-Reply-To: <20170308123417.GA3981@kroah.com>
Hi,
On Wednesday 08 March 2017 06:04 PM, Greg Kroah-Hartman wrote:
> On Wed, Mar 08, 2017 at 05:49:43PM +0530, Vignesh R wrote:
>> Passing "serial" as name during request_irq() results in all serial port
>> irqs have same name. This does not help much to easily identify which
>> irq belongs to which serial port instance. Therefore pass dev_name()
>> during request_irq() so that better identifiable name is listed for
>> serial ports in cat /proc/interrupts output.
>>
>> Output of cat /proc/interrupts
>> Before this patch:
>> 26: 689 0 GICv2 309 Edge serial
>> After this patch:
>> 26: 696 0 GICv2 309 Edge 2530c00.serial
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> I need a "full" name here, unless you really do sign legal documents
> with just one letter as a last/sur-name?
>
Its perfectly alright not to expand surname here in India. FWIW, my ID
cards also have the same name.
I have been contributing to the kernel with above Signed-off-by line in
the past and would want to continue to use the same.
--
Regards
Vignesh
next prev parent reply other threads:[~2017-03-09 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 12:19 Vignesh R
2017-03-08 12:34 ` Greg Kroah-Hartman
2017-03-09 14:37 ` Vignesh R [this message]
2017-03-12 20:05 ` Andy Shevchenko
2017-03-14 13:44 ` Vignesh R
2017-03-14 15:59 ` Andy Shevchenko
2017-03-15 6:10 ` Jisheng Zhang
2017-03-15 11:42 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435d73f7-d057-631b-8d00-8639d764414f@ti.com \
--to=vigneshr@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®