From: "Rafał Miłecki" <rafal@milecki.pl>
To: Jon Mason <jon.mason@broadcom.com>, David Miller <davem@davemloft.net>
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Hari Vyas <hariv@broadcom.com>
Subject: Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug
Date: Fri, 3 Feb 2017 22:44:50 +0100 [thread overview]
Message-ID: <43694eda-e7fd-0df5-6bec-147770e04d5c@milecki.pl> (raw)
In-Reply-To: <1486156133-5639-3-git-send-email-jon.mason@broadcom.com>
On 02/03/2017 10:08 PM, Jon Mason wrote:
> From: Hari Vyas <hariv@broadcom.com>
>
> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
> bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
> chopping and the wrong mac address was configured.
>
> Signed-off-by: Hari Vyas <hariv@broadcom.com>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
> Fixes: 4e209001b86 ("bgmac: write mac address to hardware in ndo_set_mac_address")
I think you were going to Cc stable?
next prev parent reply other threads:[~2017-02-03 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 21:08 [PATCH v2 0/2] net: ethernet: bgmac: bug fixes Jon Mason
2017-02-03 21:08 ` [PATCH v2 1/2] net: ethernet: bgmac: init sequence bug Jon Mason
2017-02-03 21:41 ` Rafał Miłecki
2017-02-03 22:34 ` Jon Mason
2017-02-03 21:08 ` [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug Jon Mason
2017-02-03 21:44 ` Rafał Miłecki [this message]
2017-02-03 21:49 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43694eda-e7fd-0df5-6bec-147770e04d5c@milecki.pl \
--to=rafal@milecki.pl \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=hariv@broadcom.com \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®