mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: <linux-kernel@vger.kernel.org>
Subject: [PATCH] i386: int3 adjustment
Date: Tue, 08 Nov 2005 17:52:59 +0100	[thread overview]
Message-ID: <4370E5FB.76F0.0078.0@novell.com> (raw)
In-Reply-To: <4370AEE1.76F0.0078.0@novell.com>

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Remove conditionals from the way INT3 is handled; since the IDT gate
is always set up as an interrupt gate, the restore_interrupts() call
should also always be issued, making the conditional code unnecessary.

From: Jan Beulich <jbeulich@novell.com>

(actual patch attached)


[-- Attachment #2: linux-2.6.14-i386-int3.patch --]
[-- Type: application/octet-stream, Size: 1297 bytes --]

Remove conditionals from the way INT3 is handled; since the IDT gate
is always set up as an interrupt gate, the restore_interrupts() call
should also always be issued, making the conditional code unnecessary.

From: Jan Beulich <jbeulich@novell.com>

--- 2.6.14/arch/i386/kernel/traps.c	2005-10-28 02:02:08.000000000 +0200
+++ 2.6.14-i386-int3/arch/i386/kernel/traps.c	2005-11-04 17:00:47.000000000 +0100
@@ -447,9 +447,6 @@ fastcall void do_##name(struct pt_regs *
 }
 
 DO_VM86_ERROR_INFO( 0, SIGFPE,  "divide error", divide_error, FPE_INTDIV, regs->eip)
-#ifndef CONFIG_KPROBES
-DO_VM86_ERROR( 3, SIGTRAP, "int3", int3)
-#endif
 DO_VM86_ERROR( 4, SIGSEGV, "overflow", overflow)
 DO_VM86_ERROR( 5, SIGSEGV, "bounds", bounds)
 DO_ERROR_INFO( 6, SIGILL,  "invalid operand", invalid_op, ILL_ILLOPN, regs->eip)
@@ -676,7 +673,6 @@ void unset_nmi_callback(void)
 }
 EXPORT_SYMBOL_GPL(unset_nmi_callback);
 
-#ifdef CONFIG_KPROBES
 fastcall void __kprobes do_int3(struct pt_regs *regs, long error_code)
 {
 	if (notify_die(DIE_INT3, "int3", regs, error_code, 3, SIGTRAP)
@@ -687,7 +683,6 @@ fastcall void __kprobes do_int3(struct p
 	restore_interrupts(regs);
 	do_trap(3, SIGTRAP, "int3", 1, regs, error_code, NULL);
 }
-#endif
 
 /*
  * Our handling of the processor debug registers is non-trivial.

  parent reply	other threads:[~2005-11-08 16:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 12:57 [PATCH] i386: export genapic again Jan Beulich
2005-11-08 13:08 ` Arjan van de Ven
2005-11-08 13:22   ` Jan Beulich
2005-11-08 13:29 ` Adrian Bunk
2005-11-08 14:17   ` Jan Beulich
2005-11-08 16:52 ` [PATCH] i386: make trap information available to die handlers Jan Beulich
2005-11-08 16:59   ` Randy.Dunlap
2005-11-08 17:08     ` Jan Beulich
2005-11-08 17:13       ` Randy.Dunlap
2005-11-09  8:20         ` Jan Beulich
2005-11-10 12:21           ` Pavel Machek
2005-11-08 20:58       ` Richard Knutsson
2005-11-08 16:52 ` Jan Beulich [this message]
2005-11-09  8:37   ` [PATCH 1/2] i386: double fault adjustment - introduce THREAD_ORDER Jan Beulich
2005-11-09  8:38     ` [PATCH 2/2] i386: double fault adjustment Jan Beulich
2005-11-08 16:54 ` [PATCH] i386: NMI <-> debugging handler adjustments Jan Beulich
2005-11-08 16:55 ` [PATCH] i386: handle NMI case in IPI sending Jan Beulich
2005-11-08 16:55 ` [PATCH] i386: stand-alone CONFIG_PAE Jan Beulich
2005-11-08 17:02   ` Adrian Bunk
2005-11-08 17:10     ` Jan Beulich
2005-11-08 16:57 ` [PATCH] i386: adjust page fault handling Jan Beulich
2005-11-08 21:22 ` [PATCH] i386: export genapic again Randy.Dunlap
2005-11-09  8:18   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4370E5FB.76F0.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome