* [PATCH] copy_process: error path cleanup
@ 2005-12-12 18:13 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2005-12-12 18:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, Andrew Morton
This patch moves 'fork_out:' under 'bad_fork_free:',
and removes now unneeded 'if (retval)' check.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.15-rc5/kernel/fork.c~ 2005-12-06 23:33:16.000000000 +0300
+++ 2.6.15-rc5/kernel/fork.c 2005-12-12 22:55:12.000000000 +0300
@@ -1141,11 +1141,7 @@ static task_t *copy_process(unsigned lon
write_unlock_irq(&tasklist_lock);
proc_fork_connector(p);
cpuset_fork(p);
- retval = 0;
-fork_out:
- if (retval)
- return ERR_PTR(retval);
return p;
bad_fork_cleanup_namespace:
@@ -1184,7 +1180,8 @@ bad_fork_cleanup_count:
free_uid(p->user);
bad_fork_free:
free_task(p);
- goto fork_out;
+fork_out:
+ return ERR_PTR(retval);
}
struct pt_regs * __devinit __attribute__((weak)) idle_regs(struct pt_regs *regs)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-12-12 16:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-12 18:13 [PATCH] copy_process: error path cleanup Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®