mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Shuah Khan <shuah@kernel.org>,
	cocci@inria.fr, Nicolas Palix <nicolas.palix@imag.fr>,
	kernelci@lists.linux.dev, Julia Lawall <Julia.Lawall@inria.fr>,
	Bjorn Andersson <andersson@kernel.org>,
	kernel@collabora.com, Guenter Roeck <groeck@chromium.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] kselftest: Add Devicetree unprobed devices test
Date: Thu, 17 Aug 2023 12:17:38 -0400	[thread overview]
Message-ID: <439f66c9-8dc1-40d0-ae36-fb8beee5a6f1@notapiano> (raw)
In-Reply-To: <117448a6-671e-4f30-90c6-808a319caf32@sirena.org.uk>

On Thu, Aug 17, 2023 at 01:26:05PM +0100, Mark Brown wrote:
> On Fri, Aug 11, 2023 at 10:16:52AM -0400, Nícolas F. R. A. Prado wrote:
> > On Fri, Aug 11, 2023 at 02:54:56PM +0100, Mark Brown wrote:
> 
> > > This doesn't appear to produce KTAP output which is going to make it
> > > less useful for generic kselftest runners.
> 
> > Right, I'm going to need to rewrite it in C for that, but since I already had
> > the shell script done, I decided to send it as is for the RFC, since I wanted to
> > get feedback on the general approach more than anything.
> 
> I'm not clear why KTAP would require C?

When going through the documentation there was only mention of the C headers for
the kselftest framework which outputs using the KTAP format, so I thought that
was the only acceptable option.

But in the meantime while looking through the other tests I saw you've recently
added ktap output to ftrace/ftracetest. The newly added test in
net/mptcp/mptcp_lib.sh also has its own helpers for outputting in KTAP. There
are also a couple other cases of this in python.

So I can definitely do the same for this test.

Thanks,
Nícolas

  reply	other threads:[~2023-08-17 16:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 20:23 [RFC PATCH 0/2] Add a test to catch unprobed Devicetree devices Nícolas F. R. A. Prado
2023-08-10 20:23 ` [RFC PATCH 1/2] scripts/dtc: Add script to extract matchable DT compatibles Nícolas F. R. A. Prado
2023-08-10 20:23 ` [RFC PATCH 2/2] kselftest: Add Devicetree unprobed devices test Nícolas F. R. A. Prado
2023-08-11 13:54   ` Mark Brown
2023-08-11 14:16     ` Nícolas F. R. A. Prado
2023-08-17 12:26       ` Mark Brown
2023-08-17 16:17         ` Nícolas F. R. A. Prado [this message]
2023-08-17 17:39           ` Mark Brown
2023-08-10 21:43 ` [RFC PATCH 0/2] Add a test to catch unprobed Devicetree devices Rob Herring
2023-08-10 21:54   ` Rob Herring
2023-08-11 13:17   ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439f66c9-8dc1-40d0-ae36-fb8beee5a6f1@notapiano \
    --to=nfraprado@collabora.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=cocci@inria.fr \
    --cc=frowand.list@gmail.com \
    --cc=groeck@chromium.org \
    --cc=kernel@collabora.com \
    --cc=kernelci@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=nicolas.palix@imag.fr \
    --cc=robh+dt@kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®