From: Oleg Nesterov <oleg@tv-sign.ru>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>
Subject: [PATCH] fix copy_sighand() vs do_sigaction() race
Date: Wed, 08 Feb 2006 21:08:51 +0300 [thread overview]
Message-ID: <43EA33B3.4D67CA97@tv-sign.ru> (raw)
copy_sighand() should hold ->sighand->siglock while copying
->sighand->action, another thread may be doing sigaction().
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- RC-1/kernel/fork.c~ 2006-02-07 01:41:14.000000000 +0300
+++ RC-1/kernel/fork.c 2006-02-08 23:38:56.000000000 +0300
@@ -766,7 +766,9 @@ static inline int copy_sighand(unsigned
return -ENOMEM;
spin_lock_init(&sig->siglock);
atomic_set(&sig->count, 1);
+ spin_lock_irq(¤t->sighand->siglock);
memcpy(sig->action, current->sighand->action, sizeof(sig->action));
+ spin_unlock_irq(¤t->sighand->siglock);
return 0;
}
next reply other threads:[~2006-02-08 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 18:08 Oleg Nesterov [this message]
[not found] ` <43EA3611.3F4BC29D@tv-sign.ru>
[not found] ` <Pine.LNX.4.64.0602080907460.2458@g5.osdl.org>
2006-02-09 19:41 ` [PATCH] sys_signal: initialize ->sa_mask Oleg Nesterov
2006-02-09 19:41 ` [PATCH] do_sigaction: cleanup ->sa_mask manipulation Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EA33B3.4D67CA97@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®