From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@osdl.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>
Subject: [PATCH] sys_signal: initialize ->sa_mask
Date: Thu, 09 Feb 2006 22:41:41 +0300 [thread overview]
Message-ID: <43EB9AF5.AD63B9DE@tv-sign.ru> (raw)
In-Reply-To: <Pine.LNX.4.64.0602080907460.2458@g5.osdl.org>
Pointed out by Linus Torvalds.
sys_signal() forgets to initialize ->sa_mask.
( I suspect arch/ia64/ia32/ia32_signal.c:sys32_signal()
also needs this fix )
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- RC-1/kernel/signal.c~ 2006-02-01 23:38:20.000000000 +0300
+++ RC-1/kernel/signal.c 2006-02-09 23:17:54.000000000 +0300
@@ -2702,6 +2702,7 @@ sys_signal(int sig, __sighandler_t handl
new_sa.sa.sa_handler = handler;
new_sa.sa.sa_flags = SA_ONESHOT | SA_NOMASK;
+ sigemptyset(&new_sa.sa.sa_mask);
ret = do_sigaction(sig, &new_sa, &old_sa);
next prev parent reply other threads:[~2006-02-09 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 18:08 [PATCH] fix copy_sighand() vs do_sigaction() race Oleg Nesterov
[not found] ` <43EA3611.3F4BC29D@tv-sign.ru>
[not found] ` <Pine.LNX.4.64.0602080907460.2458@g5.osdl.org>
2006-02-09 19:41 ` Oleg Nesterov [this message]
2006-02-09 19:41 ` [PATCH] do_sigaction: cleanup ->sa_mask manipulation Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EB9AF5.AD63B9DE@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome