From: Corey Minyard <tcminyard@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>, Corey Minyard <minyard@acm.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ipmi/bt-bmc: remove redundant return value check of platform_get_resource()
Date: Thu, 29 Sep 2016 19:06:11 -0500 [thread overview]
Message-ID: <43ab214b-79ea-0422-1d1b-ab9e38093b6e@gmail.com> (raw)
In-Reply-To: <1474718574-14445-1-git-send-email-weiyj.lk@gmail.com>
Thanks, applied.
-corey
On 09/24/2016 07:02 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/ipmi/bt-bmc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index de64bf1..b49e613 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -432,11 +432,6 @@ static int bt_bmc_probe(struct platform_device *pdev)
> dev_set_drvdata(&pdev->dev, bt_bmc);
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "Unable to find resources\n");
> - return -ENXIO;
> - }
> -
> bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(bt_bmc->base))
> return PTR_ERR(bt_bmc->base);
>
prev parent reply other threads:[~2016-09-30 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 12:02 Wei Yongjun
2016-09-30 0:06 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ab214b-79ea-0422-1d1b-ab9e38093b6e@gmail.com \
--to=tcminyard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®