From: Saeed Mahameed <saeed@kernel.org>
To: Wang Hai <wanghai38@huawei.com>,
dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio
Date: Fri, 18 Sep 2020 10:43:50 -0700 [thread overview]
Message-ID: <43ba897632383543e6d7e82f141ad14a265b46f7.camel@kernel.org> (raw)
In-Reply-To: <20200918130210.16902-1-wanghai38@huawei.com>
On Fri, 2020-09-18 at 21:02 +0800, Wang Hai wrote:
> If the header file containing a function's prototype isn't included
> by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning:
> no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-
> Wmissing-prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning:
> no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning:
> no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning:
> no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning:
> no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning:
> no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-
> prototypes]
>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>
Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
next prev parent reply other threads:[~2020-09-18 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 13:02 Wang Hai
2020-09-18 17:43 ` Saeed Mahameed [this message]
2020-09-18 21:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ba897632383543e6d7e82f141ad14a265b46f7.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=fmanlunas@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sburla@marvell.com \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®