[PATCH] xen/pvh: add missing prototype to header

[PATCH] xen/pvh: add missing prototype to header

[Juergen Gross]

The prototype of mem_map_via_hcall() is missing in its header, so add
it.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/include/asm/xen/hypervisor.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h
index 4957f59deb40..5adab895127e 100644
--- a/arch/x86/include/asm/xen/hypervisor.h
+++ b/arch/x86/include/asm/xen/hypervisor.h
@@ -64,6 +64,7 @@ void xen_arch_unregister_cpu(int num);
 
 #ifdef CONFIG_PVH
 void __init xen_pvh_init(struct boot_params *boot_params);
+void __init mem_map_via_hcall(struct boot_params *boot_params_p);
 #endif
 
 #endif /* _ASM_X86_XEN_HYPERVISOR_H */
-- 
2.26.2

Re: [PATCH] xen/pvh: add missing prototype to header

[Dave Hansen]

On 11/19/21 7:39 AM, Juergen Gross wrote:
> The prototype of mem_map_via_hcall() is missing in its header, so add
> it.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
> Signed-off-by: Juergen Gross <jgross@suse.com>

$ git describe a43fb7da53007e67ad
v4.20-rc6-5-ga43fb7da5300

Better late than never, I guess.  I wonder what made 0day find this now.

I also guess the one mem_map_via_hcall() call site just used the __weak
definition so it didn't cause problems if there wasn't a declaration in
the header.

Re: [PATCH] xen/pvh: add missing prototype to header

[Philip Li]

On Fri, Nov 19, 2021 at 08:47:49AM -0800, Dave Hansen wrote:
> On 11/19/21 7:39 AM, Juergen Gross wrote:
> > The prototype of mem_map_via_hcall() is missing in its header, so add
> > it.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> $ git describe a43fb7da53007e67ad
> v4.20-rc6-5-ga43fb7da5300
> 
> Better late than never, I guess.  I wonder what made 0day find this now.
hi Dave, we recently find some unexpected failures for certain bisections,
with the fix, such failures are rerun to see whether we can successfully detect 
bad commits, which i think this resulted in extra but late finding on old
commit on mainline. We will keep scan our bisection process to further improve
it to reduce this kind late reporting.

> 
> I also guess the one mem_map_via_hcall() call site just used the __weak
> definition so it didn't cause problems if there wasn't a declaration in
> the header.

Re: [PATCH] xen/pvh: add missing prototype to header

[Boris Ostrovsky]

On 11/19/21 10:39 AM, Juergen Gross wrote:
> The prototype of mem_map_via_hcall() is missing in its header, so add
> it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
> Signed-off-by: Juergen Gross <jgross@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Re: [PATCH] xen/pvh: add missing prototype to header

[Boris Ostrovsky]

On 11/19/21 10:39 AM, Juergen Gross wrote:
> The prototype of mem_map_via_hcall() is missing in its header, so add
> it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: a43fb7da53007e67ad ("xen/pvh: Move Xen code for getting mem map via hcall out of common file")
> Signed-off-by: Juergen Gross <jgross@suse.com>



Applied to for-linus-5.16c


-boris