From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 2/2] media: venus: sync with threaded IRQ during inst destruction
Date: Thu, 24 Oct 2024 11:52:35 +0100 [thread overview]
Message-ID: <43dbbe57-9045-4f85-84ba-1bd5a9951fdf@linaro.org> (raw)
In-Reply-To: <20241024100857.GN1279924@google.com>
On 24/10/2024 11:08, Sergey Senozhatsky wrote:
> On (24/10/24 10:43), Bryan O'Donoghue wrote:
>>>> It also occurs to me that most of the close() operation code is shared
>>>> between venc_close() and vdec_close() a welcome patch for V3 would be to
>>>> functionally decompose the common code to a shared location.
>>>
>>> Any preferences where that "shared location" should be?
>>
>> Probably core.c is the only place we can jam stuff to be shared
>
> Ack.
>
> So, we need to
> - export a couple of symbols
> - include vdec header in core
>
> Does something like this look OK to you?
y lgtm
---
bod
next prev parent reply other threads:[~2024-10-24 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 6:16 [PATCHv2 0/2] media: venus: close() fixes Sergey Senozhatsky
2024-10-24 6:16 ` [PATCHv2 1/2] media: venus: fix enc/dec destruction order Sergey Senozhatsky
2024-10-24 8:54 ` Bryan O'Donoghue
2024-10-24 6:16 ` [PATCHv2 2/2] media: venus: sync with threaded IRQ during inst destruction Sergey Senozhatsky
2024-10-24 8:59 ` Bryan O'Donoghue
2024-10-24 9:39 ` Sergey Senozhatsky
2024-10-24 9:43 ` Bryan O'Donoghue
2024-10-24 10:08 ` Sergey Senozhatsky
2024-10-24 10:52 ` Bryan O'Donoghue [this message]
2024-10-24 11:36 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43dbbe57-9045-4f85-84ba-1bd5a9951fdf@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=senozhatsky@chromium.org \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®