From: Paolo Bonzini <pbonzini@redhat.com>
To: Space Meyer <spm@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kpsingh@kernel.org
Subject: Re: [PATCH] KVM: Deal with nested sleeps in kvm_vcpu_block()
Date: Fri, 2 Dec 2022 19:27:38 +0100 [thread overview]
Message-ID: <4405c412-f9df-ed43-8050-4d4a90d5dcc5@redhat.com> (raw)
In-Reply-To: <CAOLenvaUpnk=w7TSArwK-WqUsQDQ=GY=vOHcW4apH1E5hWTCJg@mail.gmail.com>
On 12/2/22 16:52, Space Meyer wrote:
>> Also, this does not work I think, because there is
>> add_wait_queue()/remove_wait_queue() pair. Adding it is not easy
>> because KVM is using a struct rcuwait here instead of a wait_queue_t.
> Ah, sorry. I really was a bit quick on this one. I agree nothing would ever call
> woken_wake_function, hence my patch doesn't make sense. Looking at the rcuwait
> code I don't see something similar to wait_woken.
>
> Do you see some other way we could avoid the pattern susceptible to the nested
> sleeping problem?
No, I think we should just treat them as bugs and fix them.
Paolo
prev parent reply other threads:[~2022-12-02 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 16:19 Space Meyer
2022-11-30 16:48 ` Paolo Bonzini
2022-12-02 15:52 ` Space Meyer
2022-12-02 18:26 ` Paolo Bonzini
2022-11-30 16:58 ` Paolo Bonzini
2022-12-02 15:52 ` Space Meyer
2022-12-02 18:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4405c412-f9df-ed43-8050-4d4a90d5dcc5@redhat.com \
--to=pbonzini@redhat.com \
--cc=kpsingh@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®